Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cryptopp] Pem-pack not being compiled in when selected as an option #31849

Closed
grafster opened this issue Jun 6, 2023 · 4 comments
Closed

[cryptopp] Pem-pack not being compiled in when selected as an option #31849

grafster opened this issue Jun 6, 2023 · 4 comments
Assignees
Labels
depends:upstream-changes Waiting on a change to the upstream project Stale

Comments

@grafster
Copy link

grafster commented Jun 6, 2023

Host Environment

Host: x64-windows
Compiler: MSVC 19.36.32532
vcpkg-tool version: 2023-04-07-bedcba5172f5e4b91caac660ab7afe92c27a9895

To Reproduce

vcpkg install cryptopp[pem-pack]

Then inspect the .lib file produced with dumpbin. It does not contain PEM_Load etc

dumpbin /all cryptopp-static.lib |findstr PEM_Load

Looking at the portfile.cmake file, it looks like it's been changed to copy the PEM pack headers to the destination but it's not including the source flies from the pem pack into the library.

@Adela0814 Adela0814 self-assigned this Jun 6, 2023
@Adela0814 Adela0814 added the requires:repro The issue is not currently repro-able label Jun 6, 2023
@grafster
Copy link
Author

grafster commented Jun 6, 2023

Having delved into this one a bit more, it seems like it might be a change in the cryptopp-cmake project https://github.com/abdes/cryptopp-cmake that means that it's not picking up the PEM Pack files when they are copied across to the main source directory

@Adela0814
Copy link
Contributor

Could you please submit an issue to the upstream?

@Adela0814 Adela0814 added depends:upstream-changes Waiting on a change to the upstream project and removed requires:repro The issue is not currently repro-able labels Jun 7, 2023
Copy link

github-actions bot commented Dec 5, 2023

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Dec 5, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2023
@SpaceCheetah
Copy link

abdes/cryptopp-cmake#108 fixes this in upstream, so it can be fixed here. They added the CRYPTOPP_USE_PEM_PACK cmake option to enable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends:upstream-changes Waiting on a change to the upstream project Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants