Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework custom config requests #12727

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

Colengms
Copy link
Contributor

There is a corresponding PR on the native side.

This PR removes the delivery of a custom configuration immediately before processing the didOpen, in favor of the newer mechanism of requesting each configuration as needed. The original approach predated needing configurations for other purposes, such as Find All References.

Benefits are:

  • No need to look up and deliver configurations for files opened internally by VS Code and never active in the editor.
  • Code simplification/removal. Removed QueryTranslationUnitSource request.
  • Removing the potential for a config provider to stall our message queue due and delay delivery of didOpen.

sean-mcmanus
sean-mcmanus previously approved these changes Sep 18, 2024
Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved
…nto coleng/rework_custom_config_requests
@Colengms Colengms merged commit 458ef30 into main Sep 18, 2024
6 checks passed
@Colengms Colengms deleted the coleng/rework_custom_config_requests branch September 18, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants