-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unescaping f# method names #4972
Comments
✅ Successfully linked to Azure Boards work item(s): |
Spec says: Any sequence of characters that is enclosed in double-backtick marks (
|
Not the right Amaury... Try again 😉 |
This is not an issue, I misinterpreted what the parser is doing. We only need to handle ' correctly, which we do in #4969 |
Fancy f# method names with
`` ``
are escaping according to some rules, and to make managed name full compatible we need to fully unescape. #4969 fixes the most painful problem that prevents discovering completely. But in ideal case the CIL name should be fully unescaped so it can be found through reflection.I have run a few manual tests and here are the characters that gets transformed (not exhaustive list):
\
escaped as\\
'
escaped as\'
"
escaped as\"
@
escaped as@5
I will look at more cases now.
Originally posted by @Evangelink in #4969 (comment)
AB#2020980
The text was updated successfully, but these errors were encountered: