Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit Option: Vertically AND Horizontally #298

Open
Blacklands opened this issue Oct 30, 2023 · 2 comments
Open

Fit Option: Vertically AND Horizontally #298

Blacklands opened this issue Oct 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Blacklands
Copy link

Blacklands commented Oct 30, 2023

Type of reader (if reader related)

image

Description of the new feature / enhancement

I am proposing a new fit option: Vertically and horizontally.

Currently, one can choose between either of these two, but not both at the same time.

Context:

I want to read manga on a tablet. Manga often have double spread pages from time to time. Regular pages are much taller than they are wide in terms of image dimensions, and double spreads are much wider than they are tall.
With a tablet, it makes sense to usually read in portrait mode and then rotate to landscape mode for a double spread (and then back to portrait afterwards).

With all of the four existing fit options, there is no way to have this work without pages either overflowing the screen (meaning that scrolling is necessary) in some dimension(s), or being unnaturally stretched/squished in one dimension (aspect ratio is not maintained).

(All of the following are with Clamp size to window width enabled.)

  • Free: Works fine in portrait mode (nothing overflows). In landscape mode, both single pages and double spreads overflow vertically.
  • 1:1: Same as Free.
  • Fit Vertically: Works perfectly in landscape mode with both single pages and double spreads, unnaturally stretches/squishes both when in portrait mode.
  • Fit Horizontally: Works perfectly in portrait mode with both single pages and double spreads, overflows both when in landscape mode.

To make this "workflow" possible in both orientations without any overflowing or breaking aspect ratio, one more fit option would be needed that preserves aspect ratio and does not overflow the image either.

Or let me phrase this whole thing another way:
It would be great to have a fit option that always fits the image to the screen, without overflowing the screen in either dimension, while also preserving the aspect ratio. This is no matter what dimensions or aspect ratio the screen itself and the image in question have.

An example of a reader that has this fit option: Cubari

Scenario when this would be used?

No response

Supporting information

No response

@Blacklands Blacklands added the enhancement New feature or request label Oct 30, 2023
@github-actions
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@Blacklands Blacklands changed the title Fit Option: Vertically _and_ Horizontally Fit Option: Vertically *and* Horizontally Oct 30, 2023
@Blacklands Blacklands changed the title Fit Option: Vertically *and* Horizontally Fit Option: Vertically AND Horizontally Oct 30, 2023
@mienaiyami
Copy link
Owner

Sorry, I couldn't understand. Can you show some recordings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants