Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Theme System #299

Closed
zeoint opened this issue Oct 31, 2023 · 6 comments
Closed

Better Theme System #299

zeoint opened this issue Oct 31, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@zeoint
Copy link

zeoint commented Oct 31, 2023

Type of reader (if reader related)

None

Description of the new feature / enhancement

  • The current theme system is advanced, yet complicated and has some bugs, because of how complicated it is.
  • Its really has too many properties (34) which is exhausting, tbh.
  • So I would like to suggest a simple, better and essential theme system. (In my opinion).
  • My suggested / requested theme system would have 8 properties instead of 34 properties of the current theme system.
  • This would be a simple and essential, yet ample theme system.

Simple Theme System with 8 essential, accurate properties.

No. Property Description
1. Text Color Primary Changes all primary font colors. (Including The Top Bar Yomikiru Name Color - This is currently linked to icon color).
2. Text Color Secondary Changes all secondary font colors. (Like the chapter name in the continue reading tab).
3. Icon Color Changes all the icon colors.
4. Button Color Changes all the button colors.
5. Hover Color Changes color when hovered on list, buttons, items, reader side list chapter hover, etc.
6. Code Background Color Changes the color of code background. (Code text linked to text color primary.)
7. Chapter Read Color Changes the colors of chapter read in every place like reader side list, location tab.
8. Interface / Body Color Changes the entire interface color (be it reader side list, background, top bar, etc.) except the above 7 property related ones.
Note - Reader background can be changed in color filters, so not a problem. For epubs the text, background color can also be changed in the reader settings. So keep them both as it is.
Note - Keep the existing transparent colors transparent with no change. Example - Zenmode page indicator background color.

Scenario when this would be used?

  • For a simple, essential, bug free, and ample theme system.
  • With this theme system even when a user needs to change or save a new theme he/she likes, then it would be very easy as this has 8 essential properties which are ample.

Supporting information

  • If you choose to implement this, then please keep the color filters tab in reader settings as it is, as the reader background color can be changed without affecting the entire theme of the program.
  • Also keep the font, background, progress backround, and link color of epub reader settings as it is, as they are very useful to change color directly without changing the theme / interface related color settings.
@zeoint zeoint added the enhancement New feature or request label Oct 31, 2023
@github-actions
Copy link

Thank you for your feedback and suggestions. Please note that the author might only respond on weekends, so we kindly ask for your patience and understanding.

@zeoint zeoint changed the title Simple Theme System Simple And Ample Theme System Oct 31, 2023
@omodia
Copy link

omodia commented Oct 31, 2023

Nice idea.

@zeoint zeoint changed the title Simple And Ample Theme System Simple Theme System Nov 2, 2023
@zeoint zeoint mentioned this issue Nov 8, 2023
@zeoint zeoint changed the title Simple Theme System Better Theme System Nov 8, 2023
@mienaiyami
Copy link
Owner

It does sound like a nice idea but I can already imagine people asking for more customization options.
But that aside, there's another issue that's causing so many theme variables, that is the whole UI. I'm not good at UI design and it resulted in using many colors.
I do plan to do something similar however, but it will only be possible if I plan to change UI design.

Though, personally I don't think its that much needed as you can already see in default theme, they are linked to few main colors.
Link feature was literally implemented for this reason.

@zeoint
Copy link
Author

zeoint commented Nov 9, 2023

Though, personally I don't think its that much needed as you can already see in default theme, they are linked to few main colors.
Link feature was literally implemented for this reason.

Yes, the link is indeed a great feature. If you wish to change the theme / UI design, then do keep the link feature.

It does sound like a nice idea but I can already imagine people asking for more customization options.

Aren't 8-10 properties already plenty enough? If you plan to do it, do keep this in mind.

But that aside, there's another issue that's causing so many theme variables, that is the whole UI.

Wouldn't it be solved if the primary text colors are all linked to the primary text and all the 8 properties to their respective code (Relevant ones), so why would you need to changed the UI design to link the variables to the code?

I'm not good at UI design and it resulted in using many colors.

I personally think the UI is intuitive, one of the best, and to the point without any unnecessary elements.

I do plan to do something similar however, but it will only be possible if I plan to change UI design.

Cool.

@omodia
Copy link

omodia commented Nov 10, 2023

Link feature was literally implemented for this reason.

Yes, the link is indeed a great feature. If you wish to change the theme / UI design, then do keep the link feature.

You didn't get what the dev said. The dev said that you could just link the properties you don't need to a single property to mimic your feature request process.

@zeoint
Copy link
Author

zeoint commented Jan 21, 2024

I am closing this because this feature request is indeed unnecessary and waste of time.

As you and @omodia said, there is already 'link' to mimic this process and tbh 'link' is a better thought out and future proof idea than my idea which is reducing properties which other users might need and request in the future.

So its better to have more properties. Having link and more properties is a win-win for all users.

I apologize for wasting your time.

@zeoint zeoint closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants