Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some events with recurrence-id are not meant to be exceptions but ocurrences #24

Open
dancalderon opened this issue Jul 17, 2023 · 2 comments

Comments

@dancalderon
Copy link

There are some events where the library misuses the isRecurrenceException method.

BEGIN:VEVENT DESCRIPTION:the description UID:040000008200E00074C5B7101A82E00800000000E02A9BC02E82D701000000000000000 010000000BA756286EA265A41AB00CB3B15394D45 RECURRENCE-ID;TZID=America/Denver:20230717T100000 SUMMARY:FW: DigiCert/Connect Status Call DTSTART;TZID=America/Denver:20230717T100000 DTEND;TZID=America/Denver:20230717T110000 CLASS:PUBLIC PRIORITY:5 DTSTAMP:20230717T143408Z TRANSP:OPAQUE STATUS:CONFIRMED SEQUENCE:32 LOCATION:See below X-MICROSOFT-CDO-APPT-SEQUENCE:32 X-MICROSOFT-CDO-BUSYSTATUS:BUSY X-MICROSOFT-CDO-INTENDEDSTATUS:BUSY X-MICROSOFT-CDO-ALLDAYEVENT:FALSE X-MICROSOFT-CDO-IMPORTANCE:1 X-MICROSOFT-CDO-INSTTYPE:3 X-MICROSOFT-DONOTFORWARDMEETING:FALSE X-MICROSOFT-DISALLOW-COUNTER:FALSE END:VEVENT

In this event, we have a recurrence-id and a UID, but this event should not be included in the exdates, instead, it should be displayed the 20230717

it seems like this data has the problem from the root since ical-js mark this event as an exception, but I'm wondering if there is something we can do about it, like checking the EXDATE

``

@mifi
Copy link
Owner

mifi commented Jul 18, 2023

could you open an issue in ical-js if the root issue is there?

@srabraham
Copy link

This may have been fixed in recent years in ical.js. Note that ical-expander still depends on ical.js 1.2.2, but I found that my recurrence problems went away when I upgraded to ical.js 1.5.0 (or, better yet, 2.1.0, the most recent version).

i.e. @mifi maybe pin to a more recent version and check that in/make a new tag

npm install ical.js@2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants