From 4e85230f4918f728bb1ec48b99e5b2bfde000264 Mon Sep 17 00:00:00 2001
From: Mike Heft <mikeheft@gmail.com>
Date: Sun, 7 Jul 2024 14:08:23 -0600
Subject: [PATCH] fix deploy slack

---
 .github/workflows/terraform_and_deploy.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/terraform_and_deploy.yaml b/.github/workflows/terraform_and_deploy.yaml
index fff68ce..735176d 100644
--- a/.github/workflows/terraform_and_deploy.yaml
+++ b/.github/workflows/terraform_and_deploy.yaml
@@ -73,7 +73,7 @@ jobs:
 
     if: |
       always() &&
-      needs.terraform.result == 'success' || needs.terraform.result == 'skipped' &&
+      (needs.terraform.result == 'success' || needs.terraform.result == 'skipped') &&
       needs.rubocop.result == 'success' &&
       needs.rspec.result == 'success'
     steps:
@@ -140,8 +140,8 @@ jobs:
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
           SLACK_MESSAGE: |
-            Your deployment of [${{ github.event.pull_request.title }}](${{ github.event.pull_request.html_url }})
-            has failed'
+            Your deployment of  ${{ github.even.pull_request.title }} <https://${{ github.event.pull_request.html_url }}|#${{ github.event.number }}
+            has failed
         with:
           status: ${{ job.status }}
           emoji: ":error:"