Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utest generation doesn't always respect symbols #850

Open
marten-voorberg opened this issue Jun 1, 2024 · 0 comments
Open

Utest generation doesn't always respect symbols #850

marten-voorberg opened this issue Jun 1, 2024 · 0 comments

Comments

@marten-voorberg
Copy link
Contributor

marten-voorberg commented Jun 1, 2024 •
edited
Loading

The utest generation in stdlib/stdlib/utest-generate.mc does not deal with Names that have the same string but a distinct symbol properly. This is because some of the generated code uses nameGetStr for the names in generated code.

This can be fixed by replacing the usage of nameGetStr by something that generates distinct strings for distinct names. This could be done by concatenating sym2hash or by tracking a unique string per symbol in some environment like is done in stdlib/mexpr/pprint.mc.

miking/stdlib/mexpr/pprint.mc

Line 37 in 24505bd

nameMap: Map Name String,

@marten-voorberg marten-voorberg changed the title Utest Generation Doesn repsect symbols at all times. Utest generation doesn't always respect symbols Jun 1, 2024
@marten-voorberg marten-voorberg mentioned this issue Jun 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marten-voorberg