Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Pause Current Effect / Voting Round whilst the game is in a 'Loading' state #14

Open
milkytoasto opened this issue Oct 3, 2022 · 2 comments · Fixed by #25

Comments

@milkytoasto
Copy link
Owner

Describe the solution you'd like
When the game is in a loading screen, such as one you encounter when warping in DSR, the current effect and/or voting round should be paused until the loading state is changed.

There is likely a byte in memory that holds if the game is currently loading, that we can check for and read from.

Additional context
We may also want to take into consideration if the user backs out to the menu, whether or not we need to re-apply effects after a loading screen, and what to do if the game is exited/crashes out. But some of these considerations could get their own issues.

@milkytoasto
Copy link
Owner Author

At some point this effect has stopped working. I'll need to do more research to find out why. Hitting a Windows API error when it tries to access the pointer I decided upon for checking if the game is in a loading state, likely need to find a proper address/offset pair.

DSREffect has had the corresponding isLoading code commented out.

@milkytoasto milkytoasto reopened this Feb 26, 2023
@milkytoasto
Copy link
Owner Author

This has been fixed recently alongside some of the refactoring changes.

However, there is a small defect wherein the app will hit an exception as memory cannot be written to as soon as the state changes. Might need to implement some artificial delay that kicks in after the loading stops.

Seems fixable with just an extra second of buffer, but might want to be safe for now and set an artificial delay of 3-5 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant