Fix notice

mindkomm · Jul 8, 2020 · 1b7307f · 1b7307f
1 parent f08064a
commit 1b7307f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Types
 
+## 2.5.1 - 2020-07-08
+
+- Fixed a PHP notice.
+
 ## 2.5.0 - 2020-07-08
 
 - Fixed `sortable` parameter for the `admin_columns` option. Sorting didn’t work properly before. It should work now.

diff --git a/lib/Post_Type_Columns.php b/lib/Post_Type_Columns.php
@@ -132,6 +132,7 @@ public function sort_by_meta( \WP_Query $query ) {
 		if ( ! $query->is_main_query()
 			|| $typenow !== $this->post_type
 			|| empty( $orderby )
+			|| ! isset( $this->columns[ $orderby ] )
 			|| 'meta' !== $this->columns[ $orderby ]['type']
 		) {
 			return;