Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts #59

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix conflicts #59

merged 1 commit into from
Sep 19, 2024

Conversation

onimsha
Copy link

@onimsha onimsha commented Sep 19, 2024

Signed-off-by: Alex Co alex.tuan@mindvalley.com

Description

[Provide a brief description of the changes in this PR]

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Accepted Risk

[Any know risks or failure modes to point out to reviewers]

Related Issue(s)

[If applicable, link to the issue(s) this PR addresses]

Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Signed-off-by: Alex Co <alex.tuan@mindvalley.com>
@onimsha onimsha merged commit 08af546 into main Sep 19, 2024
0 of 5 checks passed
@onimsha onimsha deleted the chore/fix-conflict branch September 19, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant