Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players executing /list_areas without the areas priv cause minetest-5.7.0 and multicraft-2.0.0 to lock up hard. #67

Open
dennisjenkins75 opened this issue Oct 20, 2023 · 2 comments

Comments

@dennisjenkins75
Copy link

dennisjenkins75 commented Oct 20, 2023

Server: EdenLost, running multicraft-2.0.0 will lock up hard (with 100% CPU usage for the server thread) if a regular player (ex: "1hit") issues /list_areas. The same command does not lockup when a full admin ("sysadmin") runs it (a huge list of areas is returned though, for every player).

1hit@EdgyNet:~$ sqlite3 -column ./worlds/world/auth.sqlite \
  "select a.name, up.privilege from auth a, user_privileges up \
    where (a.id = up.id) and (a.name in ('1hit', 'sysadmin')) and (up.privilege like '%area%');"
1hit      area_high_limit 
1hit      area_protect    
1hit      areas_high_limit
1hit      areas_protect   
sysadmin  areas           
sysadmin  areas_high_limit
sysadmin  pvp_areas_admin 

I granted areas priv to 1hit and retried /list_areas as 1hit, and the server no longer locked up.

I don't know why 1hit has seemingly duplicate privs of area_high_limit, area_protect vs areas_high_limit. I'll audit privs offline soon. Maybe the priv name changed, or maybe I screwed something up earlier. Players other than 1hit can lock up the server by issuing /list_areas and they only have the areas_protect priv and none of the others.

So it seems that anyone lacking areas, who issues /list_areas on multitest-2.0.0 with the latest version of this areas mod can lock up the server. I do not think that this is the same as issue #51.

@dennisjenkins75 dennisjenkins75 changed the title /list_areas as non-admin owning a small numer of areas causes the server to lock up with 100% CPU usage. Players executing /list_areas without the areas priv cause multicraft-2.0.0 to lock up hard. Oct 20, 2023
@dennisjenkins75
Copy link
Author

This also causes minetest-5.7.0 to lockup as well.

@dennisjenkins75 dennisjenkins75 changed the title Players executing /list_areas without the areas priv cause multicraft-2.0.0 to lock up hard. Players executing /list_areas without the areas priv cause minetest-5.7.0 and multicraft-2.0.0 to lock up hard. Feb 6, 2024
@fluxionary
Copy link
Contributor

i can run the command just fine locally with 5.8 and on the your-land server, which runs 5.7, and where i have a sizable number of areas, as an unprivileged player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants