Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds: formspec isn't updated when some player leaves game #3126

Open
ssdaniel24 opened this issue Jun 5, 2024 · 2 comments
Open

Beds: formspec isn't updated when some player leaves game #3126

ssdaniel24 opened this issue Jun 5, 2024 · 2 comments
Labels
Bug good first issue recommended for beginners to work on

Comments

@ssdaniel24
Copy link
Contributor

How to reproduce:

  1. There are 4 players on a server at night: A, B, C and D.
  2. Two of them (A, B) lie down on the beds and sleep. They see "2 of 4 players are sleeping".
  3. If third player (C) will disconnect from the server, sleeping players (A, B) will see same sign - "2 of 4 players are sleeping" and will not see "skip night" button.

Extra: But if fourth player (D) will lie down on the bed too, then formspec will be updated ("3 of 3 players are sleeping") and night will be skipped with button or automatically.

Expected behavior:

  1. If third player (C) will disconnect from the server, sleeping players (A, B) will see updated sign - "2 of 3 players are sleeping" and will able to skip night automatically or using button.
@appgurueu appgurueu added Bug good first issue recommended for beginners to work on labels Jun 5, 2024
@alexx2021
Copy link

Hello, I would like to try and solve this issue. Can I please be assigned to it?

@appgurueu
Copy link
Contributor

appgurueu commented Jun 6, 2024

Hello, I would like to try and solve this issue. Can I please be assigned to it?

Hi. I don't think we assign issues here. Just open a PR when you've solved it.

(If you're worried that others might work on it too and thus work may be wasted, note that (1) this is rare, esp. with regards to MTG; (2) it suffices that you've expressed interest in working on it here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug good first issue recommended for beginners to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants