Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniflux OAuth2 Authentication Documentation - Account Linking #2022

Closed
adinunzio10 opened this issue Aug 14, 2023 · 2 comments · Fixed by #2059 or #2060
Closed

Miniflux OAuth2 Authentication Documentation - Account Linking #2022

adinunzio10 opened this issue Aug 14, 2023 · 2 comments · Fixed by #2059 or #2060
Labels

Comments

@adinunzio10
Copy link

Hi All,

Wasn't sure where to post this so sorry if this is not in the best spot.

I set up Authentik with Miniflux today and was running into issues with how to tell authentik what scope to pass to miniflux for my login id.

I don't use emails for logins, so email scope won't work.
I tried the other 2 scopes available (openid, profile) and it doesn't work.

I set OAUTH2_USER_CREATION=true and noticed when using the other 2 scopes, my username was just blank.

I then noticed at the bottom of my settings page, there is a button to link my profile to my sso profile. I did that and bam everything works great.

So to break it down:

  1. My big ask was to update the documentation to mention the linking feature. had i not scrolled down the settings page I may have never even knew it existed!
  2. I imagine blank username shouldn't be possible, so thats more of an FYI.
  3. Also, a way to disable non-sso logins might be helpful but for now I am just doing this with my reverse proxy
@fguillot
Copy link
Member

fguillot commented Sep 9, 2023

Currently, the scopes openid and email are hardcoded:

Scopes: []string{"openid", "email"},

Some code change are required to make it configurable:

profile := &Profile{Key: o.GetUserExtraKey(), ID: userInfo.Subject, Username: userInfo.Email}

Blank usernames should be forbidden as well.

@fguillot
Copy link
Member

fguillot commented Sep 9, 2023

PR #2059 and #2060 should address this issue. Tested with Authentik with accounts with and without email.

At some point, the OIDC integration could be improved to customize the claim used to populate Miniflux's username field. It's already requested in issue #1464.

Updated documentation: https://miniflux.app/docs/howto.html#oauth2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants