Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native emoji version detection doesn't work properly #970

Open
mbasaglia opened this issue Dec 25, 2024 · 1 comment · May be fixed by #971
Open

Native emoji version detection doesn't work properly #970

mbasaglia opened this issue Dec 25, 2024 · 1 comment · May be fixed by #971

Comments

@mbasaglia
Copy link

I noticed the colorful squares from Emoji 12 don't show up in the picker:

Screenshot_20241225_092720

despite being listed in the data files as large_purple_square and similar.

After a bit of debugging it seems the code that detects the emoji version supported (https://github.com/missive/emoji-mart/blob/main/packages/emoji-mart/src/helpers/native-support.ts#L17) thinks the browser only supports up to version 11 (while it actually supports up to version 15.1)

@mbasaglia
Copy link
Author

Specifically it's this check that fails: https://github.com/missive/emoji-mart/blob/main/packages/emoji-mart/src/helpers/native-support.ts#L99

which compares the first non-zero pixel to the equivalent pixel in the repeated image. Perhaps that check is not stable due to antialiasing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant