Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This integration will soon be deprecated - Any updates? #38

Open
3ative opened this issue Aug 2, 2023 · 7 comments
Open

This integration will soon be deprecated - Any updates? #38

3ative opened this issue Aug 2, 2023 · 7 comments

Comments

@3ative
Copy link

3ative commented Aug 2, 2023

From Home Assistant:

"The eufy_vacuum custom integration is using deprecated vacuum feature"

The custom integration eufy_vacuum is extending the deprecated base class VacuumEntity instead of StateVacuumEntity.
Please report it to the author of the eufy_vacuum custom integration.

Is anyone working on this? Are there any plans to fix?

Thanks.

3ative added a commit to 3ative/eufy_robovac that referenced this issue Aug 2, 2023
The custom integration eufy_vacuum is extending the deprecated base class VacuumEntity instead of StateVacuumEntity.
Please report it to the author of the eufy_vacuum custom integration.

Works here and seems to address my issue: mitchellrj#38
@hugalafutro
Copy link

I tried your PR, and it makes the warning go away, however it breaks the status attribute of the robovac:

without the fix:
image

with the fix the status attribute is gone:
image

Any ideas? I looked at the code, but it's all just mumbo jumbo to me.

@3ative
Copy link
Author

3ative commented Aug 4, 2023

Same here - I only noticed afterwards.
I couldn't work out that status part either - nothing else I could found referenced the VacuumEntity or StateVacuumEntity.

  • It may be a Home Assistant issue now.

@hugalafutro
Copy link

hugalafutro commented Aug 4, 2023

@3ative there is apparently a fix at bmccluskey/robovac@main...CodeFoodPixels:robovac:main, but to my understanding it would only work for people who already have that integration set up, as that integration cannot be set up freshly because grabbing the token from tuya api is broken - which is why I am using this one.

Not sure if any of it is useful / applicable, just thought I'd mention it.

@3ative
Copy link
Author

3ative commented Aug 4, 2023

@hugalafutro Thanks for the info....
I've had a look through their code changes and, as you say, it's all TUYA based. However, It may give me some clues for a new PR.

  • Looking at the Home Assistant PR for "Vacuum", They state that both "VacuumEntity" AND "StateVacuumEntity" are supported now. Just "VacuumEntity" will be removed next year.
  • So there should be a way to implement the new "StateVacuumEntity" - I just need to work out how! LOL

@kenguest
Copy link

Any luck on figuring this out?

@3ative
Copy link
Author

3ative commented Nov 17, 2023

@silviudc
Copy link

silviudc commented Feb 8, 2024

Home assistant update 2024.2.0 broke this integration for me so I went to the one above, it detects my G30 but not my 15c Max so I'm stuck again :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants