Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data download fails for a course with malformed OLX data #262

Open
pdpinch opened this issue May 25, 2021 · 7 comments
Open

Data download fails for a course with malformed OLX data #262

pdpinch opened this issue May 25, 2021 · 7 comments
Assignees
@HamzaIbnFarooq
Labels
Waiting on Author

Comments

@pdpinch
Copy link
Member

pdpinch commented May 25, 2021 •
edited
Loading

Steps to Reproduce

  1. Go to https://lms.mitx.mit.edu/courses/course-v1:MITx+8.02+2021_Spring/instructor#view-data_download
  2. Click "Select a Section or Problem"
  3. Choose > Week 7 > Week 7 Sequence 1 > [3rd] Survey (you do not need to choose "Classes and Instructors" but you can. The result is the same)

Actual Result

Error: There was an error generating your report.

Expected Result

A downloadable CSV is created

Sentry error with stack trace

https://sentry.io/organizations/mit-office-of-digital-learning/issues/2328664184/?project=1757731&query=is%3Aunresolved
@pdpinch
Copy link
Member Author

pdpinch commented May 25, 2021

We're not sure how usable the captured date was, but if we could catch the assert error and do something else that allows the report to continue, we might be able to get more data into the report.

@pdpinch pdpinch mentioned this issue May 27, 2021
Closed
@HamzaIbnFarooq HamzaIbnFarooq mentioned this issue May 28, 2021
Merged
@HamzaIbnFarooq HamzaIbnFarooq self-assigned this May 28, 2021
@HamzaIbnFarooq
Copy link

HamzaIbnFarooq commented May 31, 2021 •
edited
Loading

FYI: The issue can be reproduced by creating some inconsistency in the question problem. You can follow the below steps to reproduce the issue:

  1. Create a checkboxes problem
  2. Add N options under that problem (where N is a number)
  3. Go to LMS, select and submit Nth option
  4. Go back to the studio and update the question by removing the Nth option (now the total options will be N-1)
  5. Try generating a response report for that problem, it will give Error: There was an error generating your report. error.

@HamzaIbnFarooq
Copy link

@pdpinch can we close this?

@pdpinch
Copy link
Member Author

pdpinch commented Jun 10, 2021 via email

@HamzaIbnFarooq
Copy link

HamzaIbnFarooq commented Jun 11, 2021 •
edited
Loading

Oh, sorry, I thought it's deployed. Please keep me updated as I have to update its related upstream PR (https://github.com/edx/edx-platform/pull/27858)

@HamzaIbnFarooq
Copy link

FYI: Its upstream PR (https://github.com/edx/edx-platform/pull/27858) has been merged.

@shaidar
Copy link
Collaborator

shaidar commented Jan 5, 2022

@pdpinch Can this be closed now?

blarghmatey pushed a commit that referenced this issue Sep 19, 2022
@MaferMazu
feat: add mfe_api v1
7f5eb29 
This PR adds MFE API. This is part of the work that is being done to obtain the MFE Runtime Configurations and that has been discussed in the BTR WG.

Discussion: https://discuss.openedx.org/t/how-to-use-microfrontend-in-a-multitenant-instance/6936/14?u=mafermazu
MFE Runtime configuration - eduNEXT: https://docs.google.com/document/d/1-FHIQmyeQZu3311x8eYUNMru4JX7Yb3UlqjmJxvM8do/edit?usp=sharing

feat: add lms setting to set mfe config cache (#262)

Co-authored-by: María Fernanda Magallanes Z <maria.magallanes@edunext.co>

feat: make mfe config api disabled by default (#263)

* feat: make mfe config api disabled by default

* fix: simple is better than complex

test: add mfe config tests (#264)

* test: add mfe config tests

* test: fix it and simplify it

* test: correct pylint issues

fix: correct pep 8 violations

fix: add mfe api unit test in github workflow

fix: correct unit tests

refactor: move mfe api to lms

fix: try mfe api urls without regex

fix: add app_namespace in lms urls

fix: try url without conditional

Revert "fix: try url without conditional"

This reverts commit 694aab546134b4bd9ad2642e24927b42cac24459.

fix: set enable_mfe_config_api feature to true in the tests

test: try to add failed test case

Revert "test: try to add failed test case"

This reverts commit cee6bf656ab1b96492b0b6199ddff32a6d6a65bd.

docs: improve explanation and documentation

fix: ensure the response is a json object

refactor: be consistent with the variable names

fix: allow overriding mfe api config cache timeout in production

fix: handle 404 response in view

refactor: use a guard instead if-else

feat: add the possibility to show mfe specific config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HamzaIbnFarooq HamzaIbnFarooq

Labels
Waiting on Author
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pdpinch @shaidar @HamzaIbnFarooq