Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update dependency sass to ~1.81.0" #3323

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

asadali145
Copy link
Contributor

Reverts #3313

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's disable sass automerge in Renovate as well. I think this is what we will need to add in renovate.json file:

  "packageRules": [
    {
      "matchPackages": ["sass"],
      "automerge": false
    }
  ]

@asadali145
Copy link
Contributor Author

Let's disable sass automerge in Renovate as well. I think this is what we will need to add in renovate.json file:

  "packageRules": [
    {
      "matchPackages": ["sass"],
      "automerge": false
    }
  ]

How about doing it in a followup PR as this one is just the revert of original PR?

@arslanashraf7
Copy link
Contributor

Let's disable sass automerge in Renovate as well. I think this is what we will need to add in renovate.json file:

  "packageRules": [
    {
      "matchPackages": ["sass"],
      "automerge": false
    }
  ]

How about doing it in a followup PR as this one is just the revert of original PR?

I'm fine either way. But doing it in this PR completes sounds more compelling because it will also include the reasons why we reverted the PR disabling the automerge for this. They will kind of remain connected for future visitors.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the changes. 👍

@asadali145 asadali145 merged commit eb32d8d into master Nov 22, 2024
7 checks passed
@asadali145 asadali145 deleted the revert-3313-renovate/sass-1.x branch November 22, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants