Release v2.0.0rc5

[miurahr]

---

This discussion was created from the release Reelase v2.0.0rc5.

[miurahr]

I'd like to set a target date of general release v2.0.0 in 29, Sep. 2021.

A day 29 is known as "The meat 🥩 day" in Japan, taking a Japanese pronounce ni-ku, and many steak/BBQ/beef bowl restaurants are in sale. Let's prepare a party! 🍖

[pzhlkj6612]

Go for it! More users will make developers discover more problems, whether in the code or documentation.

[ddalcino]

I don't want to ruin the party, but it looks like the upload for the continuous build failed:

Uploading release artifacts
  Error: .gravitybee\dist\latest\aqt.exe doesn't match any files

This is the sequence of events, as far as I can tell:

1. ci/build_standalone.bat runs, builds an executable, and renames it .gravitybee\dist\latest\aqt.exe
2. The svenstaro/upload-release-action@v2 action runs, and uploads .gravitybee\dist\latest\aqt.exe to the release for 2.0.0rc5
3. ???
4. The marvinpinto/action-automatic-releases@latest action runs, but cannot locate .gravitybee\dist\latest\aqt.exe.

I wonder if the marvinpinto/action-automatic-releases@latest action is somehow misinterpreting the Windows directory separators as escape sequences? 😕 I don't understand how the file could have disappeared between the two actions.

[pzhlkj6612]

Would it be possible to just use the svenstaro/upload-release-action twice? It looks like it allows you to specify a release tag and overwrite an existing file. Could that work for the continuous release?

I agree to use "svenstaro/upload-release-action". It will stop the workflow when nothing is found (main.ts#L166).

[pzhlkj6612]

Hold on a second.

It will stop the workflow when nothing is found (main.ts#L166).

The code I referenced takes effect when file_glob is enabled. If file_glob is disabled (by default) and the file parameter points to a non-existent file, it will also fail the workflow ( fs.statSync(file) at main.ts#L54).

[pzhlkj6612]

#405

[miurahr]

merged and manually uploaded aqt.exe to releases

[pzhlkj6612]

About marvinpinto/action-automatic-releases@latest . I've made marvinpinto/actions#387 and marvinpinto/actions#388 . If one of them get merged, we could go back to use marvinpinto/action-automatic-releases .

[pzhlkj6612]

Shall we append a version number to the file name of the standalone exe in the normal release (not continuous)? For example, upload a file named "aqt-v2.0.0rc5.exe" in release v2.0.0rc5.

[pzhlkj6612]

One thing I forgot to mention is that we should use "aqt.exe" as the filename in continuous releases.

Any opinions?

[pzhlkj6612]

OK, I think this could be done in #407 (comment) . Version 2.0.0 should not be blocked by this.

[miurahr]

Pushes v2 release commit now.

[pzhlkj6612]

And please pay attention to the spelling of the word "release":

- Reelase
+ Release

• https://github.com/miurahr/aqtinstall/releases/tag/v2.0.0rc3
• https://github.com/miurahr/aqtinstall/releases/tag/v2.0.0rc5

[miurahr]

Failure in test.pypi upload is not a problem.