How to unit test sagas

[mxrnx]

Hi @mizrael! Thanks for developing OpenSleigh!

I was experimenting with the framework today, and after creating a Saga with a few steps, I tried writing unit tests for it.

I thought this would be trivial: create an instance of my Saga class, and write tests for each of its methods.

However, I found that tests will fail, since the Saga's State property cannot be set without setting up the whole dependency injection chain as far as I can see. The property can also not be mocked, since its setter is private, and the Saga's SetState(TD State) method cannot be accessed either since it is internal.

Am I missing something somewhere, or is it just quite difficult to unit test Saga's? In the former case, could you please point me in the right direction, and in the latter case, I'd be glad to open an issue and submit a pull request to, for example, add an extra constructor to Saga where one can input a concrete SagaState instance.

Cheers!

[mizrael]

hi, thank you very much for reaching out! I'll be honest, I've been focusing a lot on the whole library but I think I've left this unattended. Let me think about it a bit, I'll get back to you ASAP.

Cheers!

[mizrael]

hi @knarka, I've made few changes to the code. I've decided to add a TState param to the TSaga constructor, as you suggested.
Unfortunately, this is a somewhat breaking change (albeit quite small), so I apologize if this is causing any issue.

I've also added a test project to the first sample, just to give an idea.

I still have to merge the changes into the development branch, I just wanted to know if this is a viable solution for you. You can find the changes here: 885bbdf

Thanks!

[mxrnx]

Hi! Thanks for your quick response and changes! Really appreciate it 😄

I think I can test everything I need to test like this, and even though it is indeed a breaking change, it should be easy to account for by just updating the saga constructors.

[mxrnx]

Works like a charm! Thanks again for the quick response!

[mizrael]

glad it helped! Now that we're here, do you mind telling me a bit about your use case? I'm trying to come up with a list to put on the website.

[mxrnx]

Of course. I'm splitting a very long, multi-step transaction into smaller steps. So far, using a saga seems to result in clearer code; the ability to make an early exit, clean things up, and possibly revert things if necessary is very nice.

[mizrael]

awesome. What's the industry?

[mxrnx]

Fintech