Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Works on the Evaluation Data? #1

Open
TekinGunasar opened this issue Jan 18, 2024 · 1 comment
Open

Works on the Evaluation Data? #1

TekinGunasar opened this issue Jan 18, 2024 · 1 comment

Comments

@TekinGunasar
Copy link

TekinGunasar commented Jan 18, 2024

Hi! Thank you for writing this code.

I was wondering if it has also been tested on the evaluation data? A lot of FBCSP implementations really seem to skirt around that and just test on the training data and report the test accuracy for different folds during cross validation, and when tested on the evaluation datasets do rather poorly.

I’m 99% sure your code takes into account the evaluation data, as you have a “training” parameter in your class that loads data, but if possible, I would love to be able to hear from you as well!

Thank you very much,
Tekin

@mj-sam
Copy link
Owner

mj-sam commented Jan 22, 2024

Hey Tekin!
the algorithm has been mostly tested on the evaluation set and it works properly.
Let me know if you have any questions or if there's anything else I can help you with.
Regards,
Javad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants