-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Works on the Evaluation Data? #1
Comments
Hey Tekin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! Thank you for writing this code.
I was wondering if it has also been tested on the evaluation data? A lot of FBCSP implementations really seem to skirt around that and just test on the training data and report the test accuracy for different folds during cross validation, and when tested on the evaluation datasets do rather poorly.
I’m 99% sure your code takes into account the evaluation data, as you have a “training” parameter in your class that loads data, but if possible, I would love to be able to hear from you as well!
Thank you very much,
Tekin
The text was updated successfully, but these errors were encountered: