Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH/BUG? : Allow empty-room matching of task-noise files in same session #1354

Open
berkgercek opened this issue Dec 17, 2024 · 1 comment
Open

Comments

@berkgercek
Copy link

Describe the problem

Currently MNE-BIDS' path._find_empty_room_candidates will only look for files that use the emptyroom subject ID.

The BIDS specification suggests that two possible routes to tagging empty-room recordings are possible:

  1. The subject is set to emptyroom, as implemented in MNE-BIDS, and the empty-room recordings are date-tagged using the session identifier.
  2. The task is set to noise but otherwise the subject and session identities are preserved. The empty-room recording lives in the same folder as the rest of the subject data.

I may be missing another associated part of the code, but case 2 will not be recognized if the AssociatedEmptyRoom field in the JSON sidecar is empty for the path using the empty-room candidates function.

Describe your solution

The underlying search logic for empty-room candidates should also look for task-noise files in the same directory as part of generating candidates. Whether these are date-matched is up to the dev team, but it would be really nice to have these files recognized.

Describe possible alternatives

If the feature isn't desirable to implement, it would be good to at least emit a warning that these files will not be used if they exist, or otherwise let the user know that only example 1 from the BIDS specification is being implemented.

Additional context

No response

Copy link

welcome bot commented Dec 17, 2024

Hello! 👋 Thanks for opening your first issue here! ❤️ We will try to get back to you soon. 🚴🏽‍♂️

@berkgercek berkgercek changed the title Allow empty-room matching of task-noise files in same session ENH/BUG? : Allow empty-room matching of task-noise files in same session Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant