You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The subject is set to emptyroom, as implemented in MNE-BIDS, and the empty-room recordings are date-tagged using the session identifier.
The task is set to noise but otherwise the subject and session identities are preserved. The empty-room recording lives in the same folder as the rest of the subject data.
The underlying search logic for empty-room candidates should also look for task-noise files in the same directory as part of generating candidates. Whether these are date-matched is up to the dev team, but it would be really nice to have these files recognized.
Describe possible alternatives
If the feature isn't desirable to implement, it would be good to at least emit a warning that these files will not be used if they exist, or otherwise let the user know that only example 1 from the BIDS specification is being implemented.
Additional context
No response
The text was updated successfully, but these errors were encountered:
berkgercek
changed the title
Allow empty-room matching of task-noise files in same session
ENH/BUG? : Allow empty-room matching of task-noise files in same session
Dec 18, 2024
Describe the problem
Currently MNE-BIDS'
path._find_empty_room_candidates
will only look for files that use theemptyroom
subject ID.The BIDS specification suggests that two possible routes to tagging empty-room recordings are possible:
emptyroom
, as implemented in MNE-BIDS, and the empty-room recordings are date-tagged using the session identifier.noise
but otherwise the subject and session identities are preserved. The empty-room recording lives in the same folder as the rest of the subject data.I may be missing another associated part of the code, but case 2 will not be recognized if the
AssociatedEmptyRoom
field in the JSON sidecar is empty for the path using the empty-room candidates function.Describe your solution
The underlying search logic for empty-room candidates should also look for
task-noise
files in the same directory as part of generating candidates. Whether these are date-matched is up to the dev team, but it would be really nice to have these files recognized.Describe possible alternatives
If the feature isn't desirable to implement, it would be good to at least emit a warning that these files will not be used if they exist, or otherwise let the user know that only example 1 from the BIDS specification is being implemented.
Additional context
No response
The text was updated successfully, but these errors were encountered: