Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Influx metrics: Errors aren't always errors #98

Open
franzliedke opened this issue May 20, 2019 · 0 comments
Open

Influx metrics: Errors aren't always errors #98

franzliedke opened this issue May 20, 2019 · 0 comments

Comments

@franzliedke
Copy link
Contributor

The Influx metric currently assumes that the presence of errors attached to a trace means that the trace itself failed.

In our production environment, we are also attaching temporary failures, e.g. when we retry service requests, to the trace. I guess we need new APIs to distinguish trace error state and other "failures".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant