Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File uploads: Uploaded files with spaces in the filename are not URL-encoded, making them inaccessible for download #191

Open
SebConejo opened this issue Oct 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@SebConejo
Copy link
Contributor

When I upload a file with spaces in its name, the spaces are not URL-encoded. This causes issues when trying to download the file later, as URLs cannot handle spaces directly. For example, a file named "test 02" should have its spaces encoded as %20, but it currently isn't, making the file inaccessible for download.

  1. Here we can note the file we pushed contains white spaces.
Capture d’écran 2024-10-01 à 23 34 54
  1. The response we see when trying to download this file
    { "message": "Cannot GET /storage/cats/certificate/Oct2024/1s8ug193nm1qyb7v3-Tool%20", "error": "Not Found", "statusCode": 404 }
@SebConejo SebConejo added the bug Something isn't working label Oct 1, 2024
@brunobuddy
Copy link
Contributor

@SebConejo correct we need to slugify the name before storing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants