Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.33.1 and 1.34.1] Commands with unfound elements are not failing #1617

Open
maximgeerinck opened this issue Dec 11, 2023 · 2 comments
Open

[1.33.1 and 1.34.1] Commands with unfound elements are not failing #1617

maximgeerinck opened this issue Dec 11, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@maximgeerinck
Copy link

maximgeerinck commented Dec 11, 2023 •
edited
Loading

Describe the bug

It seems like commands always return OK

To Reproduce
Steps to reproduce the behavior, e.g.:

  1. Start the simulator
  2. Run maestro studio
  3. Run the command:
tapOn: IDKANYMORE

or

assertVisible:
  text: HAHAHAHAFUFUEWHFIUFEHIUEWHFEIUWHGUWEHIGEWUIHGEWIUH

and it marked it as Correct

Expected behavior

It should fail the test

Screenshots

Screenshot 2023-12-11 at 08 40 05

Environment information (please complete the following information):

  • Maestro version 1.33.1
  • Platform:IOS
  • Framework: React Native
  • Device model and OS version: iPhone 15 Pro Max
  • Simulator, emulator or physical device: Simulator (but also on CI in maestro cloud)
  • Host [e.g. Mac M1, Windows, Linux, etc]: Mac M2

Additional Info

  • Commented out my .maestro/config.yaml file as well to test
@maximgeerinck maximgeerinck added the bug Something isn't working label Dec 11, 2023
@maximgeerinck maximgeerinck changed the title [1.33.1] [1.33.1] Commands with unfound elements are not failing Dec 11, 2023
@maximgeerinck maximgeerinck changed the title [1.33.1] Commands with unfound elements are not failing [1.33.1 and 1.34.1] Commands with unfound elements are not failing Dec 11, 2023
@rob4226
Copy link

rob4226 commented Mar 16, 2024

Same thing on v1.36.0, every command run in studio completes successfully, even with id and/or text selectors that do not exist. When run with test they fail as they should.

@rob4226 rob4226 mentioned this issue Mar 16, 2024
Open
@NorseGaud
Copy link

Still a problem on 1.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maximgeerinck @NorseGaud @rob4226