From 27bd4f42ce3decd16630a51d0923543adda06620 Mon Sep 17 00:00:00 2001 From: Adrian Palacios Date: Wed, 14 Jun 2023 21:12:55 +0000 Subject: [PATCH] Remove comment about `kani-driver` code. --- rfc/src/rfcs/0007-global-conditions.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/rfc/src/rfcs/0007-global-conditions.md b/rfc/src/rfcs/0007-global-conditions.md index 5c7ec4875cf6..06e25475d7d2 100644 --- a/rfc/src/rfcs/0007-global-conditions.md +++ b/rfc/src/rfcs/0007-global-conditions.md @@ -67,7 +67,7 @@ However, we may consider adding a new subsection `Global conditions` to the `Ref ## Detailed Design The only component to be modified is `kani-driver` since that's where verification results are built and determined. -But given the growing complexity of `kani-driver`, we should consider moving the logic related to global conditions onto a new crate. +But we should consider moving this logic into another crate. We don't need new dependencies. The corner cases will depend on the specific global conditions to be implemented. @@ -78,9 +78,6 @@ As mentioned earlier, we're proposing this change to help users understand globa In many cases, global conditions empower users to write harnesses which weren't possible to write before. As an example, the `#[kani::should_panic]` attribute allowed users to write harnesses expecting panic-related failures. -On the other hand, this proposal will add a significant amount of code to `kani-driver`. -It's possible to move some code into another crate, but even then some code will be added in `kani-driver`. - Also, we don't really know if more global conditions will be requested in the future. We may consider discarding this proposal and waiting for the next feature that can be implemented as a global condition to be requested.