Support GetPublicPath from federation options

[judithhartmann]

Currently setting getPublicPath in the plugin config seems to have no effect (I could not find the function i passed there anywhere in my build output).

Expected behaviour described here:
https://module-federation.io/configure/getpublicpath.html

[zhangHongEn]

understand

[gioboa]

@judithhartmann we are working on it. can you create an example based on this example of these special config pls?
You can post here the changes I guess. Thanks, this will help us a lot.

[judithhartmann]

I will.

I also saw in your PR that there seems to be a static public path option that i did not find in the docs, I will try that as well.

The issue i ran into my project is that we have the modules in a cdn but the remoteEntry was trying to load the get from a relative path, that of course did not match the actual location of that filw

[gioboa]

Thanks, with your example we can certify the new implementation 👏

[judithhartmann]

I tried to build an example from your PR #108, unfortunately i got stuck because getPublicPath does not seem to be applied.

I would assume i'll find something related to it in the build output of the remote.
i basically just set getPublicPath: `function () { return 'http://localhost:4001/custom-prefix/'}`, in the remote, but i could not find '/custom-prefix' in the output at all.
if it works i would find some traces of it right?

[gioboa]

Yep, the PR it's not complete yet. I was waiting for the test case. Can you share with me your configurations please ?

---

It's
getPublicPath: function () { return 'http://localhost:4001/custom-prefix/'}
right? How can I test of it's working or not?

[judithhartmann]

Here are all my modifications
judithhartmann@01502f5

I modified the vite dev and preview server, so they will serve all files with the /custom-prefix as well, without using base.

Basically the test would be, that every file requested from the host from this remote (not just remoteEntry.js) also contains the custom prefix.

[gioboa]

@judithhartmann I'm wondering if we can consider using the Vite experimental.renderBuiltUrl configuration instead of supporting the getPublicPath option.

[judithhartmann]

it looks like this might work

however, from user perspective, since since plugin does not have it's own extensive docs, but relies on https://module-federation.io/ it might be confusing, as getPublicPath is documented over there to achieve this behaviour

[gioboa]

Yup, you are right, we can add a section in the README for that. Would you like to drop a PR for that?

[gioboa]

I added a warning
This is nice for the DX. @judithhartmann Can you verify that that Vite config is solving the case pls?

[zhangHongEn]

Even if experimental.renderBuiltUrl is set, manifest.json still needs to have getPublicPath, and they need to work together. I’ve restored the code.

[judithhartmann]

Hi @gioboa, sorry for the delay.

I tried out the experimental.renderBuiltUrl. (Branch)

  experimental: {
    renderBuiltUrl: (filename) => {
      return `http://localhost:4001/custom-prefix/${filename}`;
    },
  },

Unfortunately the only place where i can find the custom-prefix in the built output is in the index.html, so it does not have an influence on the remotyEntry.js nor any files related to it.

In the vite dev example, all files aside from the remoteEntry.js where loaded without the prefix

combined with @zhangHongEn concerns, i think we need to reopen this.

[judithhartmann]

if i set the base in the vite config (which works for static paths), i can see the custom-prefix here in dist/assets/virtual_mf-exposes-[HASH.js. probably getPublichPath should have an influence on this one as well.

const assetsURL = function(dep) { return "/custom-prefix/"+dep };