Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename pending request channels with amount of pending requests #68

Open
violine1101 opened this issue Jul 2, 2020 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@violine1101
Copy link
Member

violine1101 commented Jul 2, 2020

It would be great if the pending request channels would be renamed so that the amount of unresolved requests is immediately visible without the need to visit the channel. (e.g. #20-java-pending-requests)

This may be a bit difficult to realize, not only because the bot needs to know how many unresolved requests there are left (which means it also needs to track message deletions etc.) but also because there's a rate limit on how often discord bots can edit channel titles. I'm not entirely sure as for what the exact rate limits are, but they exist (the Minecraft commands discord has had trouble with the channel renaming rate limit, but they also use it very extensively).

@violine1101 violine1101 added the enhancement New feature or request label Jul 2, 2020
@violine1101
Copy link
Member Author

To clarify, I'm talking about our internal channels here that aren't visible to the public. The reactions in the public channel don't really have much to do with this, and keeping track of unsolved requests that way would probably be very inefficient.

But thinking about it, we know how many messages there are in the internal channels, so that value could probably be used.

@violine1101
Copy link
Member Author

Some considerations from #136:

  • The rate limit for channel name and topic updates is 2 updates per 10 minutes per channel. If we exceed that, the bot will get rate limited.
  • The amount of messages in a channel should always be known because all messages are loaded on startup. Still it might make more sense to have a global count of pending requests for each channel and update that as requests are opened/closed, in case the cache is invalidated for some reason.
  • It might make sense to add the amount of pending requests to public request channels too, although perhaps in the channel topic instead of the channel name.

@violine1101 violine1101 assigned violine1101 and unassigned chandler05 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants