Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localStorage access is unguarded #30

Open
1j01 opened this issue Aug 12, 2022 · 2 comments
Open

localStorage access is unguarded #30

1j01 opened this issue Aug 12, 2022 · 2 comments
Labels
optimization optimization request

Comments

@1j01
Copy link

1j01 commented Aug 12, 2022

Even with isSaveState: false, it gets "DOMException: Failed to read the 'localStorage' property from 'Window': Access is denied for this document" when storage is disabled in the browser settings.

All usage of localStorage should be wrapped in a try-catch.

@Sandstedt
Copy link
Member

Are you trying to run this dev tool in a headless browser or in node? This tool is not suppose to be shipped into production, but just be a browser based tool for you to edit curves in. So no need to run this when not developing in client side.

@1j01
Copy link
Author

1j01 commented Aug 24, 2022

I just thought I would report this issue since this demo doesn't work for me. I can pan the view, but no curve is displayed:
image

My actual use case is a little outside the library's immediate scope, and I expect to fork it to achieve what I want (although the API could be generalized to support this). Rather than doing animation, I want to control a mouse acceleration curve for a head tracking system. So instead of time, the input axis is head speed, and then the output axis is pointer speed.
I'd like to present a simpler UI to users, ultimately, but first I need to understand the range of curves that works well.
And I may leave a full curve editor in as an advanced option, if it's not too much trouble to maintain. We'll see.

And I could roll my own curve editor but this one looks very nice and polished, and even fits the color scheme of my app :)

@xavierfoucrier xavierfoucrier added the optimization optimization request label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization optimization request
Projects
None yet
Development

No branches or pull requests

3 participants