Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Spree::LineItem ID within Mollie order line metadata field #55

Open
vernondegoede opened this issue Jan 15, 2019 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@vernondegoede
Copy link
Contributor

This will allow us to remove this workaround: https://github.com/mollie/spree-mollie-gateway/blob/master/app/models/spree/mollie/order_serializer.rb#L196 and store it within the line's metadata.

More information: https://docs.mollie.com/changelog/v2/changelog#monday-14th

@vernondegoede vernondegoede self-assigned this Jan 15, 2019
@vernondegoede
Copy link
Contributor Author

Please make sure this change is backward compatible. When no metadata is present on the order line, fall back to the current implementation ("#{line.id}-#{line.variant.sku}").

@vernondegoede vernondegoede removed their assignment May 3, 2019
@vernondegoede vernondegoede added the enhancement New feature or request label May 3, 2019
@Oldharlem
Copy link
Collaborator

Please note that the refunds depend on the #{line.id}-#{line.variant.sku} structure. Need to abstract the line_item mollie identifier in its own method to ensure implementation wide support for the chosen identifier

@vernondegoede
Copy link
Contributor Author

Agreed. Would be good to reuse this logic.

@Oldharlem
Copy link
Collaborator

Fixed by #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants