Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #46

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Dev #46

merged 3 commits into from
Sep 6, 2023

Conversation

paulsaxe
Copy link
Collaborator

@paulsaxe paulsaxe commented Sep 6, 2023

No description provided.

@paulsaxe paulsaxe added bug Something isn't working enhancement New feature or request labels Sep 6, 2023
@paulsaxe paulsaxe requested a review from seamm September 6, 2023 17:04
Copy link
Contributor

@seamm seamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.20% ⚠️

Comparison is base (4bc3e90) 15.47% compared to head (76c377d) 15.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   15.47%   15.28%   -0.20%     
==========================================
  Files          33       33              
  Lines        3121     3160      +39     
==========================================
  Hits          483      483              
- Misses       2638     2677      +39     
Flag Coverage Δ
unittests 15.28% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
lammps_step/lammps.py 6.20% <0.00%> (-0.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seamm seamm merged commit e125790 into main Sep 6, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants