From 1cfa9d83d683b6a6c56fe3e2c4cd2fdc3faea3b2 Mon Sep 17 00:00:00 2001 From: vjeffrey Date: Mon, 28 Aug 2023 08:40:00 -0600 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20gcp=20compute=20instances=20shou?= =?UTF-8?q?ld=20be=20labelled=20as=20platform=20instance=20not=20image=20(?= =?UTF-8?q?#1591)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit also, i didn't touch the logic for this part right now, but why are we entirely skipping windows instances, like not discovering them at all? @preslavgerchev @imilchev does one of you know? ``` if disksContainWindows(i.Disks) { log.Debug().Msgf("skipping windows instance %s", i.Name) continue } ``` --- motor/discovery/gcp/mql_asset_objects.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/motor/discovery/gcp/mql_asset_objects.go b/motor/discovery/gcp/mql_asset_objects.go index 3650779c5e..16895a6f0e 100644 --- a/motor/discovery/gcp/mql_asset_objects.go +++ b/motor/discovery/gcp/mql_asset_objects.go @@ -106,7 +106,7 @@ func computeInstances(m *MqlDiscovery, project string, tc *providers.Config, sfn name: i.Name, id: i.Id, service: "compute", - objectType: "image", + objectType: "instance", }, }, tc) a.State = mapInstanceStatus(i.Status)