From fbc6412d93dedcfbb9464f884af9b04d747650a5 Mon Sep 17 00:00:00 2001 From: vjeffrey Date: Mon, 6 Nov 2023 09:11:24 -0700 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20ensure=20we=20do=20not=20return?= =?UTF-8?q?=20ecr=20image=20assets=20with=20no=20connection=20info=20from?= =?UTF-8?q?=20discovery=20call=20(#2465)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- providers/aws/resources/discovery.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/providers/aws/resources/discovery.go b/providers/aws/resources/discovery.go index a0aec806b0..7b908ea9bc 100644 --- a/providers/aws/resources/discovery.go +++ b/providers/aws/resources/discovery.go @@ -208,7 +208,6 @@ func Discover(runtime *plugin.Runtime, filters connection.DiscoveryFilters) (*in } in.Spec.Assets = append(in.Spec.Assets, list...) } - return in, nil } @@ -295,7 +294,12 @@ func discover(runtime *plugin.Runtime, awsAccount *mqlAwsAccount, target string, if !imageMatchesFilters(a, filters) { continue } - assetList = append(assetList, addConnectionInfoToEcrAsset(a, conn)) + ecrAsset := addConnectionInfoToEcrAsset(a, conn) + if len(ecrAsset.Connections) > 0 { + assetList = append(assetList, ecrAsset) + } else { + log.Warn().Str("name", ecrAsset.Name).Msg("cannot scan ecr image with no tag") + } } case DiscoveryECS: res, err := NewResource(runtime, "aws.ecs", map[string]*llx.RawData{})