Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cache of slots per class in FMRelationSlot #21

Open
NicolasAnquetil opened this issue Feb 28, 2021 · 2 comments
Open

Remove cache of slots per class in FMRelationSlot #21

NicolasAnquetil opened this issue Feb 28, 2021 · 2 comments

Comments

@NicolasAnquetil
Copy link
Contributor

I found a case (PowerBuilder) were this cache was causing bugs
Is it really needed ?

@jecisc
Copy link
Member

jecisc commented Feb 28, 2021

I've added the cache because it cause a great performance regression on MooseQuery on big models. The introduction of the cache improved a lot the performances of Benoit's tooling

@badetitou
Copy link
Member

Yep. The cache is super important in my tool.

Is it creates bug, I know that before there was a strategy pattern that allows us to use or not cache

We can do it again maybe?
By default use cache ( it is nice for user imo ). And one can choose to not use it.

Are you ok with that @NicolasAnquetil?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants