Replies: 1 comment 1 reply
-
I think the first proposal is better and even more suitable for a multi-platform approach. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Currently
borders
slice is used to create aliases of borders we want to use in our application, for example:The problem is that there is no way to reference the slice
colors
to use colors from the theme or the sliceborderWidths
to use mapped border widths. In the same way we cannot reference mappedborder styles
, but in this case the only possible values that we can set are the ones supported by border-style property.I wanted to improve
borders
since I think currently it's a little bit useless. I'm opening this discussion to have some feedback about 2 proposals:First proposal
Make the border value an object with width, color, and style:
In this way the generated border will always reference acceptable values.
Second proposal
The second proposal is to remove
borderStyles
slice since we can only accept values described here so I don't think we need a dedicated theme sliceBeta Was this translation helpful? Give feedback.
All reactions