{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":851651279,"defaultBranch":"main","name":"substrait-cpp","ownerLogin":"mortbopet","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-09-03T13:36:07.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/16338943?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726063462.0","currentOid":""},"activityList":{"items":[{"before":"03760889013210041038398e595639d04b4f1cc3","after":"eb121e849b1cdb26e48819da273cdd0c90d6fe2b","ref":"refs/heads/patch-6","pushedAt":"2024-09-12T10:45:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Add missing include\n\nint32_t, ... uses `<cstdint>`.","shortMessageHtmlLink":"Add missing include"}},{"before":null,"after":"452d614b85f9c4c88f147d593b0b27a79353d6bf","ref":"refs/heads/outputFieldReferences_hotfix","pushedAt":"2024-09-11T14:04:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Comment out outputFieldReferences-related code/issue","shortMessageHtmlLink":"Comment out outputFieldReferences-related code/issue"}},{"before":"59b8a2ca73958a064d713d2315d375c353d39dc7","after":"91638927ea6cbdbe6a1e705f509a588d1af6f5e0","ref":"refs/heads/dev/mpetersen/struct_is_not_class","pushedAt":"2024-09-07T07:50:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Don't predeclare a class as a struct","shortMessageHtmlLink":"Don't predeclare a class as a struct"}},{"before":"f7e538fc9baabdb7e2b7e3e51dde98c49a30ff82","after":"bd445e81fa0626755c44a735a7384918fb60098b","ref":"refs/heads/dev/mpetersen/io_namespace_pollution","pushedAt":"2024-09-07T07:50:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"format","shortMessageHtmlLink":"format"}},{"before":"8e77fae19e559ada183b497940783bcd897f18b6","after":"e967b33133c86c84504cc5d800bb13694707cf40","ref":"refs/heads/patch-5","pushedAt":"2024-09-07T07:48:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Don't throw away `visit` result in BasePlanProtoVisitor\n\n`visitPlan` is marked `protected`, meaning that non-subclasses of `BasePlanProtoVisitor` (which is probably what'll initiate the `visit` most of the time) cannot have access to the `visit` result.\r\n\r\nIs there a specific reason that the traversal result has been hidden? If not, i suggest this change.\r\n\r\nIf so, subclasses are obviously free to implement a `visitWithResult` function to do the same thing.","shortMessageHtmlLink":"Don't throw away <code>visit</code> result in BasePlanProtoVisitor"}},{"before":"1e1e508f098d97d0827d4b538b0b670a8c429321","after":"620bddd226d56b5d06938fb1d4ada7a83d7906df","ref":"refs/heads/dev/mpetersen/dont_namespace_def","pushedAt":"2024-09-07T07:47:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"explicit namespace for free function","shortMessageHtmlLink":"explicit namespace for free function"}},{"before":"c5151ab5d6bfd32912979b41cad79358921d6509","after":"29bb216587c0078f225ab8485fdabcda21c0f751","ref":"refs/heads/dev/mpetersen/all_changes","pushedAt":"2024-09-06T14:27:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"return visit result","shortMessageHtmlLink":"return visit result"}},{"before":"ef0bbe5126203c095beacab487a2994b5a0b9b88","after":"8e77fae19e559ada183b497940783bcd897f18b6","ref":"refs/heads/patch-5","pushedAt":"2024-09-06T14:25:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Don't throw away `visit` result in BasePlanProtoVisitor\n\n`visitPlan` is marked `protected`, meaning that non-subclasses of `BasePlanProtoVisitor` (which is probably what'll initiate the `visit` most of the time) cannot have access to the `visit` result.\r\n\r\nIs there a specific reason that the traversal result has been hidden? If not, i suggest this change.\r\n\r\nIf so, subclasses are obviously free to implement a `visitWithResult` function to do the same thing.","shortMessageHtmlLink":"Don't throw away <code>visit</code> result in BasePlanProtoVisitor"}},{"before":"fbd65f8d493520c9cebf7cf5da83eb833524381d","after":"c5151ab5d6bfd32912979b41cad79358921d6509","ref":"refs/heads/dev/mpetersen/all_changes","pushedAt":"2024-09-06T12:44:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Just disable this error for now","shortMessageHtmlLink":"Just disable this error for now"}},{"before":"23ee3904acd8e33461ee37d73faa83289aaed1ee","after":"fbd65f8d493520c9cebf7cf5da83eb833524381d","ref":"refs/heads/dev/mpetersen/all_changes","pushedAt":"2024-09-06T12:27:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Fix namespace pollution on Windows\n\nAs described in https://github.com/substrait-io/substrait-cpp/issues/116, the `io.h` file in this project conflicts with `io.h` of windows.\n\nThis fixes that (in the somewhat narrow compilation path that i'm exercising) by removing `include/substrait/common` from the include path, and instead relying on the (already existing) full include-path namespacing instead of relative includes of `io.h`.","shortMessageHtmlLink":"Fix namespace pollution on Windows"}},{"before":null,"after":"f7e538fc9baabdb7e2b7e3e51dde98c49a30ff82","ref":"refs/heads/dev/mpetersen/io_namespace_pollution","pushedAt":"2024-09-06T12:26:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Fix namespace pollution on Windows\n\nAs described in https://github.com/substrait-io/substrait-cpp/issues/116, the `io.h` file in this project conflicts with `io.h` of windows.\n\nThis fixes that (in the somewhat narrow compilation path that i'm exercising) by removing `include/substrait/common` from the include path, and instead relying on the (already existing) full include-path namespacing instead of relative includes of `io.h`.","shortMessageHtmlLink":"Fix namespace pollution on Windows"}},{"before":"699cbf4871df5a49ec285f21e116c1c26b778e5c","after":"23ee3904acd8e33461ee37d73faa83289aaed1ee","ref":"refs/heads/dev/mpetersen/all_changes","pushedAt":"2024-09-06T11:49:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"ff","shortMessageHtmlLink":"ff"}},{"before":null,"after":"59b8a2ca73958a064d713d2315d375c353d39dc7","ref":"refs/heads/dev/mpetersen/struct_is_not_class","pushedAt":"2024-09-06T11:43:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Don't predeclare a class as a struct","shortMessageHtmlLink":"Don't predeclare a class as a struct"}},{"before":"ef0bbe5126203c095beacab487a2994b5a0b9b88","after":"699cbf4871df5a49ec285f21e116c1c26b778e5c","ref":"refs/heads/dev/mpetersen/all_changes","pushedAt":"2024-09-06T11:26:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Static everything","shortMessageHtmlLink":"Static everything"}},{"before":null,"after":"ef0bbe5126203c095beacab487a2994b5a0b9b88","ref":"refs/heads/dev/mpetersen/all_changes","pushedAt":"2024-09-06T09:31:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Prevent gtest compiler/link errors on windows (#111)\n\nSubstrait-cpp is (i assume) intended to embed into other projects, so other subprojects should adhere to parent projects' settings. For GTest on windows, this requires that `gtest_force_shared_crt ` is enabled\r\n([doc](https://github.com/google/googletest/blob/main/googletest/README.md)).","shortMessageHtmlLink":"Prevent gtest compiler/link errors on windows (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2507488803\" data-permission-text=\"Title is private\" data-url=\"https://github.com/substrait-io/substrait-cpp/issues/111\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/substrait-io/substrait-cpp/pull/111/hovercard\" href=\"https://github.com/substrait-io/substrait-cpp/pull/111\">substrait-io#111</a>)"}},{"before":"163f2d2d7066b3a44d1ffbd82e9cfa0be103468e","after":"1e1e508f098d97d0827d4b538b0b670a8c429321","ref":"refs/heads/dev/mpetersen/dont_namespace_def","pushedAt":"2024-09-05T15:39:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"explicit namespace for free function","shortMessageHtmlLink":"explicit namespace for free function"}},{"before":null,"after":"163f2d2d7066b3a44d1ffbd82e9cfa0be103468e","ref":"refs/heads/dev/mpetersen/dont_namespace_def","pushedAt":"2024-09-05T13:41:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Don't define member functions inside a nested namespace\n\nThis trips up MSVC, in that member functions aren't properly included in the object files of the various translation units. Generally, this should be fixed by having a `using` declaration in a .cpp file. From my experience, a general good practice is to never nest definitions in namespaces, unless that is only visible from within a translation unit (e.g. a `detail` namespace inside a .cpp file).\n\nThis doesn't fix all of the places in the code where this pattern is used - only the (narrow) compile path that i've been excercising. Someone should probably go through the rest of the codebase and apply this - will be needed if/when a windows CI pipeline is added.","shortMessageHtmlLink":"Don't define member functions inside a nested namespace"}},{"before":"9737507dd0e77ed14e418bacd874c71bf561892c","after":"be3d6f90cc96b7c6aa170e3c321afc05e444d8d2","ref":"refs/heads/patch-4","pushedAt":"2024-09-05T13:16:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Set ANTLR4CPP_STATIC for everything that links against ANTLR\n\nIt isn't sufficient to rely on a single [`add_definitions`](https://github.com/substrait-io/substrait-cpp/blob/cc8d08af7a7ff4b65d0081fc18f9bb243fe85824/src/substrait/textplan/parser/grammar/CMakeLists.txt#L8) when defining this. Other things which pulls in ANTLR headers _must_ define this as well - if not, we end up with very hard to debug symbol visibility errors.\r\n\r\nSet it as a public compile definition on the target to ensure the definition propagates.","shortMessageHtmlLink":"Set ANTLR4CPP_STATIC for everything that links against ANTLR"}},{"before":"633686438d0cfeb9e7da9849d8b5c1271ed95679","after":"8a69bbc8ceb355a180ed67336afd99656b91f85d","ref":"refs/heads/patch-3","pushedAt":"2024-09-05T11:52:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"format","shortMessageHtmlLink":"format"}},{"before":"4087ae39740a979dbed3109e960ea192e8a44676","after":"633686438d0cfeb9e7da9849d8b5c1271ed95679","ref":"refs/heads/patch-3","pushedAt":"2024-09-05T11:46:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"format","shortMessageHtmlLink":"format"}},{"before":"9737507dd0e77ed14e418bacd874c71bf561892c","after":"4087ae39740a979dbed3109e960ea192e8a44676","ref":"refs/heads/patch-3","pushedAt":"2024-09-05T11:12:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Prevent gtest compiler/link errors on windows\n\nSubstrait-cpp is (i assume) intended to embed into other projects, so other subprojects should adhere to parent projects' settings.\r\nFor GTest on windows, this requires that ... is enabled ([doc](https://github.com/google/googletest/blob/main/googletest/README.md)).","shortMessageHtmlLink":"Prevent gtest compiler/link errors on windows"}},{"before":"aa89232c72b324417aab1ac5db85db84551b9725","after":"50f5e1b408bcff0befd3999bc13af4665721428b","ref":"refs/heads/patch-2","pushedAt":"2024-09-04T07:42:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"format","shortMessageHtmlLink":"format"}},{"before":"8d5da6b540333b55a9b8ce08b99d032e651c92cd","after":"34e3f289aa1d592b3922e9172314f824dcd4fc67","ref":"refs/heads/dev/mpetersen/win_build","pushedAt":"2024-09-04T07:41:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Minimum viable changes for Windows build\n\nThis + PRs https://github.com/substrait-io/substrait-cpp/pull/109 and https://github.com/substrait-io/substrait-cpp/pull/108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.","shortMessageHtmlLink":"Minimum viable changes for Windows build"}},{"before":null,"after":"8d5da6b540333b55a9b8ce08b99d032e651c92cd","ref":"refs/heads/dev/mpetersen/win_build","pushedAt":"2024-09-03T13:54:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Minimum viable changes for Windows build\n\nThis + PRs https://github.com/substrait-io/substrait-cpp/pull/109 and https://github.com/substrait-io/substrait-cpp/pull/108 should be sufficient for a minimum-viable Windows (MSVC) build of this project.","shortMessageHtmlLink":"Minimum viable changes for Windows build"}},{"before":"1dbf98b548de3ef11cac2a42075b87f57e7004b9","after":"aa89232c72b324417aab1ac5db85db84551b9725","ref":"refs/heads/patch-2","pushedAt":"2024-09-03T13:48:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Don't concatenate paths in `--proto_path`\n\n`protoc`'s `--proto_path` argument is expected to be provided multiple times if multiple directories are to be considered. Concatenating with `:` is invalid on some systems (Windows):\r\n\r\n```sh\r\n> protoc --help\r\n  -IPATH, --proto_path=PATH   Specify the directory in which to search for\r\n                              imports.  May be specified multiple times;\r\n                              directories will be searched in order.  If not\r\n                              given, the current working directory is used.\r\n                              If not found in any of the these directories,\r\n                              the --descriptor_set_in descriptors will be\r\n                              checked for required proto file.\r\n```","shortMessageHtmlLink":"Don't concatenate paths in <code>--proto_path</code>"}},{"before":"1dbf98b548de3ef11cac2a42075b87f57e7004b9","after":"6b187d2e24d96ac2c7b873b7b8ce137311b2d270","ref":"refs/heads/patch-1","pushedAt":"2024-09-03T13:41:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mortbopet","name":"Morten Borup Petersen","path":"/mortbopet","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16338943?s=80&v=4"},"commit":{"message":"Use CMake built-in dir create function instead of hard-coded `mkdir`\n\n... Because all systems may not play nice with `mkdir -p`.","shortMessageHtmlLink":"Use CMake built-in dir create function instead of hard-coded <code>mkdir</code>"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMlQxMDo0NTozNS4wMDAwMDBazwAAAAS0QWwp","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xMlQxMDo0NTozNS4wMDAwMDBazwAAAAS0QWwp","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wM1QxMzo0MTo0OS4wMDAwMDBazwAAAASroRme"}},"title":"Activity · mortbopet/substrait-cpp"}