Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermodal bus + boat request not working #434

Open
laem opened this issue Feb 7, 2024 · 2 comments
Open

Intermodal bus + boat request not working #434

laem opened this issue Feb 7, 2024 · 2 comments

Comments

@laem
Copy link

laem commented Feb 7, 2024

I've added some GTFS in Brittany that give access to island connections by boat. I'm happy to see that they work from port to port.

But when I'm trying to plan an intermodal route that brings the user from somewhere in the city (A) further from the port (B), to the island (C), Motis fails.

You can try the requests on my instance : https://motis.cartes.app.

This is quite surprising since the route from A to B returns lots of buses (+ walk) in less than one second.

image

Then, from the port (B, but A on the following capture) to the island (C, but B on the following capture), it works too in less than 2 seconds.
image

Going from A to C returns nothing and takes quite some time.

image

Is there a request parameter (not active by default in the demo app) that I'm missing to enable this bus - boat intermodal routing ?

@laem
Copy link
Author

laem commented Feb 7, 2024

Something strange is that for a seemingly more complex request with bus + train + bus + boat, it succeeds (though slowly).

image

This is quite cool.

So, either :

  • there are some particularities (bugs ?) in the GTFS files that make the request from Lorient to Groix to fail, but from Rennes to Ouessant to succeed
  • there is a bug or parameter that I ignore in Motis that makes the first request fail but the second to succeed.

@felixguendling
Copy link
Member

I'm not sure, if I understand your test case. I understand it's a journey A->B->C. Can you please give exact coordinates for A, B and C that I can copy & paste into the MOTIS UI?

With my limited understanding of your test case: it looks like there is a walk required at B, so it is probably not just B but B1 where you arrive and B2 where you depart with the next trip. If B1 and B2 are not linked explicitly (which is definitely the case if they are from different GTFS datasets), it depends on the maximum distance between stops where nigiri (I guess you use the new core?) links stops. One parameter you can try to increase is nigiri.link_stop_distance.

Another parameter which is currently hardcoded and cannot be configured at runtime is this one:
https://github.com/motis-project/nigiri/blob/166411ed9e80347a5b51a34150dc11bda44f3c03/src/loader/build_footpaths.cc#L212

Can you please check if there's B or actually B2 and B2 and if there are B1 and B2 what's the distance B1, B2 (direct line distance) and are they from different datasets (which is important because for different datasets the hardcoded variable is relevant for those from the same dataset the configation variable nigiri.link_stop_distance)? If they are from the same dataset, you might check if there's a footpath given in transfers.txt and whether the time given there is sufficient to make the transfer (difference between arrival and departure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants