Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Videos with different aspect ratio than device are zoomed in #8252

Closed
Teelry opened this issue Feb 9, 2020 · 123 comments
Closed

Videos with different aspect ratio than device are zoomed in #8252

Teelry opened this issue Feb 9, 2020 · 123 comments
Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days Feature:Media Feature:Toolbar Address bar, see also Feature:Search S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist

Comments

@Teelry
Copy link

Teelry commented Feb 9, 2020

Videos with a smaller aspect ratio will be zoomed in. For example, videos in 16:9 running on a device that has an 18:9 aspect ratio will zoom them in, making the user able to scroll up/down the video, which can be problematic if the user is watching a video with subtitles. It should be either not zoomed in, or given the choice to.

I realise this is low priority, but it is still a problem.

Status as of Feb-2022: YouTube issue is not a Firefox issue. They are doing user agent detection that only works in Chrome. A Chrome engineer has opened a YouTube bug with them. It is possible to work around this using Ublock

┆Issue is synchronized with this Jira Task

@github-actions github-actions bot added the needs:triage Issue needs triage label Feb 9, 2020
@kbrosnan kbrosnan added Feature:Media E2 Estimation Point: easy, half a day to 2 days S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist 🐞 bug Crashes, Something isn't working, .. needs:group-triage labels Feb 11, 2020
@boek boek added this to Content Consumption in Workflow Feb 11, 2020
@boek boek added needs:investigation and removed needs:triage Issue needs triage labels Feb 11, 2020
@boek
Copy link
Contributor

boek commented Feb 11, 2020

Reproducible on a pixel 3

@ghost
Copy link

ghost commented Feb 16, 2020

The bug also occurs when a landscape video is made full-screen in the portrait mode. The video is scrollable vertically even though the whole video is in view.

@raindrum
Copy link

raindrum commented Feb 22, 2020

Seems to happen with every video, whether in landscape or not, at least on an XZ1 Compact running LineageOS 16. Every video can be scrolled up or down, regardless of whether its dimensions match the screen. Most (all?) of the time, the entire video is onscreen at the middle scroll level, but it automatically scrolls to the top or bottom if I take my finger off the screen.

EDIT: I believe Issue #7333, which was closed in favor of this ticket, describes the issue better, at least in my experience.
For me, all videos, regardless of aspect ratio, scroll. But only when the toolbar is set to the top. I set it to the bottom, and fullscreen videos now display properly.

@st3fan st3fan added this to Fenix Media Issues in A-C: Media Mar 27, 2020
@jsdz
Copy link

jsdz commented Apr 3, 2020

It doesn't allow scrolling now, which means that the bottom of the video including the controls is permanently cut off until you exit fullscreen..

@ekager
Copy link
Contributor

ekager commented Apr 11, 2020

Pulling in the info from the comment here: #7333 (comment)

This seems to be much worse when toolbar is set to the top than when it is set to the bottom. You should not be able to scroll in fullscreen mode for either configuration.

@ekager ekager moved this from Fenix Media Bugs to Eng Ready Backlog - Fenix Team in A-C: Media Apr 11, 2020
@vesta0 vesta0 removed this from Content Consumption in Workflow Apr 23, 2020
@agi
Copy link
Contributor

agi commented Aug 19, 2020

Copying from https://bugzilla.mozilla.org/show_bug.cgi?id=1654800#c3

I cannot repro this in GVE, on my phone vimeo shows the entire UI on GVE and clips it heavily on Fenix.

I suspect this is because Fenix does not remove the dynamic toolbar space when going fullscreen?

@freebrowser1
Copy link

This is a different problem than I reported in #14548. This ticket here is about that the video zooms too much which makes the subtitle invisible, but what I see is that it does not zoom enough leaving a wide white bar on the right side and a narrow white bar on the left side, but showing subtitles normally.

@Strugatsky
Copy link

I'd like to add this was fixed by the addon "Ultrawideo" on Fennec, not available in Fenix of course. When setting the mode to "normal" videos were played back normally. I hope this info can help someone working on this bug.

@cizkek
Copy link

cizkek commented Sep 2, 2020

#14533

Unlike mentioned on above post, in 14533 it is not zoomed in. You can not scroll. The video is cropped and stuck so the bottom half is gone.

@OrionRed
Copy link

OrionRed commented Jul 8, 2021

Fix for Moto g9 Plus:
Go to Settings > Display > Advanced > Full Screen > Turn on Firefox

This worked great and is something that will carry over even if I refresh my Firefox on my phone. Even shows the captions correctly.

What I notice is that the "top" of my screen is now white where before it was covered by the oversized player. So now the scaling matches the actual screen size.

@jxu
Copy link

jxu commented Jul 8, 2021 via email

@yaomtc
Copy link

yaomtc commented Aug 19, 2021

Has anyone fixed or worked around this on Vimeo?

EDIT: I have since unsubscribed

@BloodRaven0
Copy link

@yaomtc I can confirm that I don't experience the bug anymore in Youtube and some... sites that require private browsing. I just tried on Vimeo however, and the bug is still there. For the time being, I guess you can use the Vimeo app, until it is fixed.

@RC-3
Copy link

RC-3 commented Feb 8, 2022

Still broken. Observed on YouTube video with a 4:3 aspect on a phone (Pixel) with a 20:9 aspect. The video fills from the left to right edge, cropping off the bottom half.
Tested with FF Android 96.3.1, FF Focus Android 96.3.1, and FF Nightly Android 98.0a1. Works on Chrome for Android.

Workaround: create a custom addon collection with a User Agent switcher addon.
Import the collection to FF Nightly Android.
Change UA to Chrome for Android. Now fullscreen works properly.

@joshtriplett
Copy link

I can confirm that as well. Widescreen videos seem to work, but 4:3 videos or other videos with unusual aspect ratios don't.

@karlcow
Copy link

karlcow commented Feb 11, 2022

@acalarch
Copy link

I am using the CSS below to fix the problem using uBlock. It pins the video to the top of the screen, scales it to be as large as possible. I find the other CSS style for the player container is not needed. I've made this change on other websites as well. 99% of the time you only have to change the domain. Typically video works as a selector. If it doesn't you can use a PC to visit the mobile website and figure out what selector you need.

m.youtube.com##video:style(max-height: 100% !important; position: fixed !important; top: 0px !important)
As youtube changes, I have had to adjust this CSS filter a few times. Specifically Linus Tech Tips on youtube seems to be a good way to test.

Note: this "breaks" non-full screen and I cannot get the :fullscreen selector to work in uBlock. If you manage to get the fullscreen selector to work.. this fix shouldn't break normal youtube. For now I always go full screen.

@ComfortableEast
Copy link

ComfortableEast commented Apr 29, 2022

m.youtube.com##.html5-video-player :style(max-height: 100vh !important)
youtube.com##player-container :style(max-height: 100vh !important)


the above seems to get everything where it should be regardless of me using the desktop site or not, captions or not or wide mode or not.

It is not working for me. Could you please help.
After setting up the filter when I tap the fullscreen button 🔳 while on potrait mode -> it still crops out the bottom 10% of the screen.
But if I do the same while already being on landscape mode it does work. Now I don't know if this is due to the filter or not because I haven't used mobile yt site on landscape mode before.
The 2 ways that work me for in the 1st scenario is (this was working for me before setting up the filter)

  1. After going full-screen, I swipe down to see notification and swipe up. This corrects everything somehow
  2. After going full-screen I select a video quality menu from the top right setting button without actually choosing anything and getting back to the video.

I made sure that ublock origin has "my filters" ticked on
I don't know if other add-on I have could possibly interact with it.. (I'm also using sponsor block)
Any suggestion would be very helpful
thank you!

@ZagButNoZig
Copy link

ZagButNoZig commented Aug 26, 2022

@RByers Sorry to bother you. Do we have any updates for this? The issue is still present on my Galaxy S20 FE

@no-identd
Copy link

So, I wonder:

@AlexEastwood can you install some variant of Firefox you haven't ever installed before yet on that phone (e.g. nightly) and check whether that fresh install defaults to that setting (which in this case you couldn't have had preconfigured from any previous install), or whether it installs with it defaulting to on nowadays?

@no-identd
Copy link

no-identd commented Nov 15, 2022

Reason I ask is because I have a notchless ultrawide phone and so I don't have most of the issues here but something feels off about the aspect ratio on certain video streaming platforms but I can't say for certain whether it's my imagination or not, so I ran into this open issue and went through the various fixes proposed here, which doesn't seem to have changed anything (but also, my possible symptoms, if indeed they are symptoms, aren't QUITE the same as anyone else's here), but I found that at least Firefox Beta on my phone auto defaulted to having that setting turned on already

@no-identd
Copy link

no-identd commented Nov 15, 2022

As far as I can tell all possibly related bugzilla bug entries have gotten fixed recently. The only possible outstanding one I could see consists of https://bugzilla.mozilla.org/show_bug.cgi?id=1007286 but that one doesn't really count for the purposes of this issue I'd claim.

Does anyone here still experience any symptoms, and if so, which?

(BESIDES YouTube)

@gabrielluong gabrielluong changed the title [Bug] Videos with different aspect ratio than device are zoomed in Videos with different aspect ratio than device are zoomed in Jan 30, 2023
@gabrielluong
Copy link
Member

Moved to bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1813883

Change performed by the Move to Bugzilla add-on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. E2 Estimation Point: easy, half a day to 2 days Feature:Media Feature:Toolbar Address bar, see also Feature:Search S2 Major Functionality/product severely impaired and a satisfactory workaround doesn't exist
Projects
Toolbar/Refresh issues
Needs Investigations
A-C: Media
  
Fenix Eng-Ready Bug Backlog
Development

No branches or pull requests