Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Investigate client reports of invalid dh #1417

Open
jrconlin opened this issue Jul 17, 2020 · 2 comments
Open

Investigate client reports of invalid dh #1417

jrconlin opened this issue Jul 17, 2020 · 2 comments
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.

Comments

@jrconlin
Copy link
Member

See: mozilla/application-services#3364

@jrconlin jrconlin added the 3 Estimate - m - This is a small change, but there's some uncertainty. label Jul 17, 2020
@jrconlin jrconlin added this to Backlog: Misc in Services Engineering via automation Jul 17, 2020
@rfk
Copy link

rfk commented Jul 20, 2020

TL;DR the rust code doesn't handle quoted values when parsing the Encryption or Crypto-Key headers, ref mozilla/application-services#3365

I think it's some to close this, unless you think it'd be worth autopush doing a bit of normalization here on the server side.

@jrconlin
Copy link
Member Author

It's not a bad idea for the server to normalize values where appropriate. The opposite option would be to reject the request as invalid, but I think that might harm the library consumers more than the library authors.

It's a minor fix in any case, so we can at least consider it on the server. I still think the client should also normalize where and when possible in order to avoid future fragility issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.
Projects
Services Engineering
  
Backlog: Push
Development

No branches or pull requests

2 participants