Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add default dependencies if none exist #589

Open
fbertsch opened this issue Aug 10, 2020 · 2 comments
Open

Don't add default dependencies if none exist #589

fbertsch opened this issue Aug 10, 2020 · 2 comments

Comments

@fbertsch
Copy link
Contributor

Currently, we add the default Glean dependency if none exist. However this runs contrary to expectations; we now have tables for e.g. firefox-ios with Android-specific fields.

We should instead allow there to be no dependencies.

This change will be backwards-incompatible with existing tables, since it will drop fields. We should be able to deal with this by using a SELECT * EXCEPT on the existing data. Deploying this change will require coordination with ops, as described in this bug.

cc @mdboom @Dexterp37

@Dexterp37
Copy link
Collaborator

Ouch :D

@fbertsch
Copy link
Contributor Author

Since we're simply dropping columns, we could manually remove these columns from the views instead. The downside being we need to keep the columns during dependency generation (in some way), but the upside around deploy may be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants