Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait for Phabricator events in the 'events' service, wait through a Taskcluster hook instead #2518

Open
Tracked by #2273
marco-c opened this issue Nov 14, 2024 · 0 comments

Comments

@marco-c
Copy link
Collaborator

marco-c commented Nov 14, 2024

Taskcluster now supports triggering a webhook through a unique url (with a token).
We could build a new hook that is triggered by each Phabricator diff (same config as currently), creating a task associated to the diff.
That task would run the same workflow as events:

  • Clone base repo, using a Taskcluster cache and robustcheckout
  • Apply the diff on tip
  • Push to try
  • Update phabricator harbormaster state for the diff

This would resolve the issues around disk space that we have on Heroku, allowing us to do things like #2004 and #2204.
This would also allow us to make the 'events' service slimmer. If we do both this and #945, we could get rid of the 'events' service altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant