Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determinant #667

Open
JohannesEngels opened this issue Oct 9, 2024 · 1 comment
Open

Determinant #667

JohannesEngels opened this issue Oct 9, 2024 · 1 comment

Comments

@JohannesEngels
Copy link

JohannesEngels commented Oct 9, 2024

A suggestion for src/arraymancer/linear_algebra/decomposition.nim: Seems that the computation of the determinant of a matrix is missing so far. It could be easily achieved by means of the LU-decomposition, as the determinant is just the product of the diagonal elements of the matrix U - up to the sign! Therefore it would be very helpful to give out also the number of permutations or at least the pivot_indices vector. (Of course I am talking about proc lu_permuted; in the current stage it is a bit cumbersome to determine the number of permutations from the output.)

@Vindaar
Copy link
Collaborator

Vindaar commented Oct 11, 2024

That would certainly be a useful addition. Do you feel like taking a stab at implementing it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants