Check that pointers are ok before access #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
commented
Nov 15, 2024
inst/include/dust2/r/helpers.hpp
Outdated
Comment on lines
649
to
655
| inline void check_externalptr_valid(SEXP ptr, const char * context) { | ||
| if (!R_ExternalPtrAddr(ptr)) { | ||
| cpp11::stop("Pointer has been serialised, cannot continue safely (%s)", | ||
| context); | ||
| } | ||
| } | ||
|
|
weshinsley
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of a group of changes before I even get to Thom's problem.
This PR adds a check before every single access to a pointer that it is not NULL. This will prevent crashes when the user has serialised an object and tried to access it (which happens on save to disk).
I'll come up with a safe way of roundtripping a created model soon, but this will be much nicer than a crash at least!