Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action for publishing packages fails #8

Closed
mrmorrandir opened this issue Apr 13, 2024 · 2 comments · Fixed by #10
Closed

GitHub action for publishing packages fails #8

mrmorrandir opened this issue Apr 13, 2024 · 2 comments · Fixed by #10
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@mrmorrandir
Copy link
Owner

There is a github action that publishes packages on every merge.

  1. This action should only be triggered if you really want to have a new release. (BestPractice?)
  2. The action has the same problem as the build validation for pull-requests: the integration tests fail because of missing RabbitMQ.
@mrmorrandir mrmorrandir added bug Something isn't working enhancement New feature or request labels Apr 13, 2024
@mrmorrandir
Copy link
Owner Author

@kammeph do you have an idea or a best practice for this package release process? Using tags with special names to trigger the release etc? Let me know 😉

@mrmorrandir
Copy link
Owner Author

In the corresponding branch I configured the trigger now to "manually" and "push on releases/**" - do you think this is a good practice @kammeph?

@mrmorrandir mrmorrandir pinned this issue Apr 13, 2024
@mrmorrandir mrmorrandir unpinned this issue Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants