-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor error messages when dotnet fails to initialize #30
Comments
Note: the actual issue was that my OpenSSL was out of date. |
If a dependency cannot be resolved then package restore would repeatedly be triggered. The original OmniSharp code would start a package restore if dependencies were unresolved. Then after the restore process exits a RestoreCompleted message was sent to the design time host. The design time host then sends another message back indicating that dependencies are not resolved. This again triggers the package restore to be run. The DnxProjectSystem has been changed so it does not try to restore if there are missing dependencies. Now the DnxProject itself will trigger restore if there are missing dependencies only the once after a project has been opened. This prevents the restore from being triggered repeatedly due to missing dependencies. #30 (Issue 2, 6 and 8)
On closing the solution errors due to invalid dependencies or build errors were not cleared since the build errors and tasks did not have the XProject as their owner. #30 (Issue 3)
When restoring packages the status bar will now show a "Restoring dependencies..." message. If this fails then an error message will be displayed in the status bar. Clicking the status bar will open the .NET Core Output window which will show the output from the restore process. #30 (Issue 7 and 9)
If the dotnet executable cannot be found then an error message will be displayed with information about where the .NET Core SDK can be downloaded from. Bug #30 (Issue 1)
Hopefully all these issues apart from two are fixed in version 0.5.
I could not reproduce the build succeeded message being displayed when the lock file was missing. The build would always fail.
If the lock file is empty the only error you get from the dotnet build is that the lock file is missing. The other errors are from the design time host. Hopefully with the other fixes the underlying error should be displayed so the build not showing this error should not be a problem. |
I'm filing this as a single issue, even though it could be broken down into a number of smaller bugs, as they're interrelated.
I installed the addin and created a project.
Issue 1: I didn't have .NET Core installed, and there were no error messages telling me how to fix this.
I then installed .NET Core, following all the instructions (including OpenSSL), and created a project.
The status area showed 3 errors. When I clicked on it, it showed the error pad, with the following errors:
Issue 2: It was very difficult to select the errors to copy them, as they would deselect every few seconds.
Issue 3: When I closed the project, the errors did not go away. Each time I closed and reopened it, an additional set of the same errors was added.
Issue 4: When I built the project, I would sometimes get a "build succeeded" message, despite the long pad showing errors.
Issue 5: The build log didn't show any useful error information. It didn't even show the errors.
Issue 6: The "Restoring" message in the solution pad was blinking on and off.
Issue 7: The "restoring" message and its error never showed up in the status area.
Issue 8: XS was using 100% CPU indefinitely.
When I checked the log, I saw the following message repeated a huge amount of times. Presumably the cause of issues 2, 6 and 8 is that XS is continuously retrying to restore the packages.
When I ran
dotnet restore
in the terminal, I finally found the real issue:Issue 9: the above information was not shown anywhere in XS.
The text was updated successfully, but these errors were encountered: