From cfd93b904431cab9e075b534ba801c255cc271c6 Mon Sep 17 00:00:00 2001 From: Douglas Naphas Date: Tue, 27 Feb 2024 10:52:39 -0500 Subject: [PATCH 1/2] chore(cognito): fix grammar in UserPool IDP docstrings (#29255) Closes gh-29254. ### Issue # (if applicable) Closes #29254. ### Reason for this change This fixes minor grammar issues in docs. ### Description of changes I made no functional code changes, only changes to docs via comments. I made no design decisions. ### Description of how you validated changes Doc changes only. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* --- .../aws-cdk-lib/aws-cognito/lib/user-pool-idps/amazon.ts | 6 +++--- .../aws-cdk-lib/aws-cognito/lib/user-pool-idps/apple.ts | 2 +- .../aws-cdk-lib/aws-cognito/lib/user-pool-idps/facebook.ts | 6 +++--- .../aws-cdk-lib/aws-cognito/lib/user-pool-idps/google.ts | 4 ++-- packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/oidc.ts | 2 +- packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/saml.ts | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) diff --git a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/amazon.ts b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/amazon.ts index d0bb5e432e9a3..0d166985995bf 100644 --- a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/amazon.ts +++ b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/amazon.ts @@ -8,12 +8,12 @@ import { CfnUserPoolIdentityProvider } from '../cognito.generated'; */ export interface UserPoolIdentityProviderAmazonProps extends UserPoolIdentityProviderProps { /** - * The client id recognized by 'Login with Amazon' APIs. + * The client id recognized by Login with Amazon APIs. * @see https://developer.amazon.com/docs/login-with-amazon/security-profile.html#client-identifier */ readonly clientId: string; /** - * The client secret to be accompanied with clientId for 'Login with Amazon' APIs to authenticate the client. + * The client secret to be accompanied with clientId for Login with Amazon APIs to authenticate the client. * @see https://developer.amazon.com/docs/login-with-amazon/security-profile.html#client-identifier */ readonly clientSecret: string; @@ -26,7 +26,7 @@ export interface UserPoolIdentityProviderAmazonProps extends UserPoolIdentityPro } /** - * Represents a identity provider that integrates with 'Login with Amazon' + * Represents an identity provider that integrates with Login with Amazon * @resource AWS::Cognito::UserPoolIdentityProvider */ export class UserPoolIdentityProviderAmazon extends UserPoolIdentityProviderBase { diff --git a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/apple.ts b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/apple.ts index d4514d8865d48..fff4981a39131 100644 --- a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/apple.ts +++ b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/apple.ts @@ -33,7 +33,7 @@ export interface UserPoolIdentityProviderAppleProps extends UserPoolIdentityProv } /** - * Represents a identity provider that integrates with 'Apple' + * Represents an identity provider that integrates with Apple * @resource AWS::Cognito::UserPoolIdentityProvider */ export class UserPoolIdentityProviderApple extends UserPoolIdentityProviderBase { diff --git a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/facebook.ts b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/facebook.ts index c19f1aeabfa04..9acdd68039bfe 100644 --- a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/facebook.ts +++ b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/facebook.ts @@ -12,12 +12,12 @@ export interface UserPoolIdentityProviderFacebookProps extends UserPoolIdentityP */ readonly clientId: string; /** - * The client secret to be accompanied with clientUd for Facebook to authenticate the client. + * The client secret to be accompanied with clientId for Facebook to authenticate the client. * @see https://developers.facebook.com/docs/facebook-login/security#appsecret */ readonly clientSecret: string; /** - * The list of facebook permissions to obtain for getting access to the Facebook profile. + * The list of Facebook permissions to obtain for getting access to the Facebook profile. * @see https://developers.facebook.com/docs/facebook-login/permissions * @default [ public_profile ] */ @@ -30,7 +30,7 @@ export interface UserPoolIdentityProviderFacebookProps extends UserPoolIdentityP } /** - * Represents a identity provider that integrates with 'Facebook Login' + * Represents an identity provider that integrates with Facebook Login * @resource AWS::Cognito::UserPoolIdentityProvider */ export class UserPoolIdentityProviderFacebook extends UserPoolIdentityProviderBase { diff --git a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/google.ts b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/google.ts index c99b3c49cd6de..fe750c5db1fee 100644 --- a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/google.ts +++ b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/google.ts @@ -27,7 +27,7 @@ export interface UserPoolIdentityProviderGoogleProps extends UserPoolIdentityPro */ readonly clientSecretValue?: SecretValue; /** - * The list of google permissions to obtain for getting access to the google profile + * The list of Google permissions to obtain for getting access to the Google profile * @see https://developers.google.com/identity/sign-in/web/sign-in * @default [ profile ] */ @@ -35,7 +35,7 @@ export interface UserPoolIdentityProviderGoogleProps extends UserPoolIdentityPro } /** - * Represents a identity provider that integrates with 'Google' + * Represents an identity provider that integrates with Google * @resource AWS::Cognito::UserPoolIdentityProvider */ export class UserPoolIdentityProviderGoogle extends UserPoolIdentityProviderBase { diff --git a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/oidc.ts b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/oidc.ts index b4eabc967908e..c17b48a799bdc 100644 --- a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/oidc.ts +++ b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/oidc.ts @@ -98,7 +98,7 @@ export enum OidcAttributeRequestMethod { } /** - * Represents a identity provider that integrates with OpenID Connect + * Represents an identity provider that integrates with OpenID Connect * @resource AWS::Cognito::UserPoolIdentityProvider */ export class UserPoolIdentityProviderOidc extends UserPoolIdentityProviderBase { diff --git a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/saml.ts b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/saml.ts index 518cb67b62961..a4d5bedd1051c 100644 --- a/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/saml.ts +++ b/packages/aws-cdk-lib/aws-cognito/lib/user-pool-idps/saml.ts @@ -78,7 +78,7 @@ export class UserPoolIdentityProviderSamlMetadata { } /** - * Represents a identity provider that integrates with SAML. + * Represents an identity provider that integrates with SAML. * @resource AWS::Cognito::UserPoolIdentityProvider */ export class UserPoolIdentityProviderSaml extends UserPoolIdentityProviderBase { From ccb07d0c4a4a5f2e2b220558c9efe9702e200888 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 27 Feb 2024 17:01:58 +0000 Subject: [PATCH 2/2] chore(deps): bump es5-ext from 0.10.62 to 0.10.63 (#29281) Bumps [es5-ext](https://github.com/medikoo/es5-ext) from 0.10.62 to 0.10.63.
Release notes

Sourced from es5-ext's releases.

0.10.63 (2024-02-23)

Bug Fixes

  • Do not rely on problematic regex (3551cdd), addresses #201
  • Support ES2015+ function definitions in function#toStringTokens() (a52e957), addresses #021
  • Ensure postinstall script does not crash on Windows, fixes #181 (bf8ed79)

Maintenance Improvements

  • Simplify the manifest message (7855319)

Comparison since last release

Changelog

Sourced from es5-ext's changelog.

0.10.63 (2024-02-23)

Bug Fixes

  • Do not rely on problematic regex (3551cdd), addresses #201
  • Support ES2015+ function definitions in function#toStringTokens() (a52e957), addresses #021
  • Ensure postinstall script does not crash on Windows, fixes #181 (bf8ed79)

Maintenance Improvements

  • Simplify the manifest message (7855319)
Commits

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=es5-ext&package-manager=npm_and_yarn&previous-version=0.10.62&new-version=0.10.63)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) ---
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/aws/aws-cdk/network/alerts).
--- yarn.lock | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/yarn.lock b/yarn.lock index d967a4b0e99e6..ac354b9dba1a3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7726,13 +7726,14 @@ es-to-primitive@^1.2.1: is-date-object "^1.0.1" is-symbol "^1.0.2" -es5-ext@^0.10.35, es5-ext@^0.10.46, es5-ext@^0.10.50, es5-ext@^0.10.53, es5-ext@^0.10.61, es5-ext@~0.10.14, es5-ext@~0.10.2, es5-ext@~0.10.46: - version "0.10.62" - resolved "https://registry.npmjs.org/es5-ext/-/es5-ext-0.10.62.tgz#5e6adc19a6da524bf3d1e02bbc8960e5eb49a9a5" - integrity sha512-BHLqn0klhEpnOKSrzn/Xsz2UIW8j+cGmo9JLzr8BiUapV8hPL9+FliFqjwr9ngW7jWdnxv6eO+/LqyhJVqgrjA== +es5-ext@^0.10.35, es5-ext@^0.10.46, es5-ext@^0.10.50, es5-ext@^0.10.53, es5-ext@^0.10.61, es5-ext@^0.10.62, es5-ext@~0.10.14, es5-ext@~0.10.2, es5-ext@~0.10.46: + version "0.10.63" + resolved "https://registry.npmjs.org/es5-ext/-/es5-ext-0.10.63.tgz#9c222a63b6a332ac80b1e373b426af723b895bd6" + integrity sha512-hUCZd2Byj/mNKjfP9jXrdVZ62B8KuA/VoK7X8nUh5qT+AxDmcbvZz041oDVZdbIN1qW6XY9VDNwzkvKnZvK2TQ== dependencies: es6-iterator "^2.0.3" es6-symbol "^3.1.3" + esniff "^2.0.1" next-tick "^1.1.0" es6-error@^4.0.1: @@ -8024,6 +8025,16 @@ eslint@^8: strip-ansi "^6.0.1" text-table "^0.2.0" +esniff@^2.0.1: + version "2.0.1" + resolved "https://registry.npmjs.org/esniff/-/esniff-2.0.1.tgz#a4d4b43a5c71c7ec51c51098c1d8a29081f9b308" + integrity sha512-kTUIGKQ/mDPFoJ0oVfcmyJn4iBDRptjNVIzwIFR7tqWXdVI9xfA2RMwY/gbSpJG3lkdWNEjLap/NqVHZiJsdfg== + dependencies: + d "^1.0.1" + es5-ext "^0.10.62" + event-emitter "^0.3.5" + type "^2.7.2" + espree@^7.3.0, espree@^7.3.1: version "7.3.1" resolved "https://registry.npmjs.org/espree/-/espree-7.3.1.tgz#f2df330b752c6f55019f8bd89b7660039c1bbbb6"