Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about strategy of socket closed #8

Open
huangwei1024 opened this issue Feb 3, 2015 · 0 comments
Open

about strategy of socket closed #8

huangwei1024 opened this issue Feb 3, 2015 · 0 comments

Comments

@huangwei1024
Copy link

HI,
when ClientSocket was closed, I think the Session._request_table were no longer necessary.
future under current strategy will be wait until timeout, but if Client set timeout None, when socket closed, there will be endless wait.

    def on_close(self, sock):
        # Avoid calling self.on_connect_failed after self.close called.
        if self._closed:
            return

        # if sock in self._sockets:
        #     self._sockets.remove(sock)
        #     self._connecting = 0
        # else:
        # Tornado does not have on_connect_failed event.
        self.on_connect_failed(sock)

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant