Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CRITICAL] Uninstall when symlinks are present destroys linked folders #30

Open
adamleerich opened this issue Aug 16, 2021 · 2 comments

Comments

@adamleerich
Copy link

Hello, I created a symlink to a folder on my C drive (where I keep my github projects). I had to uninstall MSYS2 while trying to fix a bug in another project's build. When uninstalling, the folder on my C drive (not properly part of the MSYS2 folder) was completely cleared. Most of the work in there is pushed to github, so I think I am OK, but I wanted to flag this.

I'll create a script that recreates the issue, if that is helpful, but I wanted to raise this now because I think it is critically dangerous, unexpected behaviour.

Thanks

--Adam

@lazka
Copy link
Member

lazka commented Aug 16, 2021

hm, that's unfortunate indeed. We just use the QT installer framework which handles the uninstall process for us, so not sure if we can change anything there.

@adamleerich
Copy link
Author

I'll do a test to see if I can recreate the issue. If I can, would you be amenable to adding an alert to the uninstaller or the website to tell people who use symlinks to be careful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants