Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More automated AUR package #10

Open
jcf opened this issue Mar 5, 2021 · 4 comments
Open

More automated AUR package #10

jcf opened this issue Mar 5, 2021 · 4 comments

Comments

@jcf
Copy link

jcf commented Mar 5, 2021

Hi @muesli,

Let me start by saying a massive thank you for building, and sharing this awesome project! I have a cool Stream Deck setup on me Linux machine thanks to you.

I noticed you (or someone using your name) created an AUR package of deckmaster, that helped me get started, but left a few steps remaining. I decided to automate some of these steps locally, and wanted to share that with you.

I've posted a comment over on the AUR website, with a patch, and I've pushed my work up to GitHub in case you'd prefer that.

What I've added:

  • udev rules that will be installed automatically (I replaced the idProduct with the ID of my Stream Deck because I wanted that name - maybe there should be four lines in this file with a name I'm not aware of?)
  • deckmaster@.path unit that will watch the symlink path you specify (e.g. systemctl --user enable deckmaster@streamdeck.path)
  • deckmaster@.service that will start deckmaster inside ~/.config/deckmaster/, and look for a deck that shares a name with your symlink path from above.

I think I've duplicated some effort as the missing ttf-roboto dependency has been mentioned in the non-git version of the package. Sorry about that!

I'm running this locally now, and it's working spectacularly! Thanks again for sharing your awesome work. 🙇

@muesli
Copy link
Owner

muesli commented Mar 6, 2021

Hey @jcf!

Thank you for your contribution and your kind words! This looks great, I'll just have to try it out on my own machine.

One thing I noticed at a first glance is the changed product ID. I assume you got a newer revision of the Streamdeck with a different ID, which I wasn't aware of. We'll probably have to support both 006c and 006d here. This also means we should update the README and/or integrate the udev rules in the repo for convenience.

We should also think about printing out the required systemd commands upon successful installation of the AUR package. Last but not least, we need to unify the -git, -bin and regular AUR package a bit.

Thanks again!

@jcf
Copy link
Author

jcf commented Mar 6, 2021

One thing I noticed at a first glance is the changed product ID. I assume you got a newer revision of the Streamdeck with a different ID, which I wasn't aware of. We'll probably have to support both 006c and 006d here. This also means we should update the README and/or integrate the udev rules in the repo for convenience.

I figured the same, but wasn't sure which product codes were which. I know the 15 button Stream Deck I have corresponds to the /dev/streamdeck entry in the udev rules.

We should also think about printing out the required systemd commands upon successful installation

This isn't something I've adding to a package before, but I see mention of .install files where printf can be used to log important information:

All important messages should be echoed during install using an .install file. For example, if a package needs extra setup to work, directions should be included.

we need to unify the -git, -bin and regular AUR package

This would be awesome! I'm not sure how best to do this. I thought maybe a contrib directory in this repo that can generate both AUR packages would be a way to share common configuration, but perhaps there's a more elegant way to do this.

@muesli
Copy link
Owner

muesli commented Mar 7, 2021

I figured the same, but wasn't sure which product codes were which. I know the 15 button Stream Deck I have corresponds to the /dev/streamdeck entry in the udev rules.

The 006c rule also matches the (first revision?) 15-button (mid-size) Stream Deck.

This isn't something I've adding to a package before, but I see mention of .install files where printf can be used to log important information:

Great, that's what I was thinking of!

This would be awesome! I'm not sure how best to do this. I thought maybe a contrib directory in this repo that can generate both AUR packages would be a way to share common configuration, but perhaps there's a more elegant way to do this.

Yeah, I think that's the easiest way to achieve this and might also help other packagers. Maybe contrib isn't the best name though, as that typically describes externally maintained stuff. I've used admin in other projects before, but that doesn't seem quite fitting either. I'm open for suggestions! 😄

Want to do the honors and come up with an initial PR for this? ❤️

@vancluever
Copy link

@muesli looks like this stalled a while ago (quite a while, hah 😉 ) but I still think it needs attention to make sure new users don't need so much manual installation. I'm happy to send off the PRs necessary to make these fixes as I've made some additions to the deckmaster-bin package locally to help with this. Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants