Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BurntSushi/xgb is deprecated, use github.com/jezek/xgb #11

Closed
tenfourty opened this issue Mar 21, 2021 · 5 comments
Closed

BurntSushi/xgb is deprecated, use github.com/jezek/xgb #11

tenfourty opened this issue Mar 21, 2021 · 5 comments

Comments

@tenfourty
Copy link
Contributor

I noticed that some some of your code can be a bit glitchy... I've not done enough investigation but I see you use the library https://github.com/BurntSushi/xgb which says:

Note that this project is largely unmaintained as I don't have the time to do
or support more development. Please consider using this fork instead:
https://github.com/jezek/xgb

@muesli
Copy link
Owner

muesli commented Mar 21, 2021

Thanks for the heads up! Can you be a bit more specific tho, please, I haven't noticed any glitches so far.

@tenfourty
Copy link
Contributor Author

tenfourty commented Mar 22, 2021

I think the main glitches I've seen are not detecting all the windows or more accurately getting the icons for all windows - a good example of an app where it fails is Spotify but there are others.
Since I raised this issue I actually recompiled deckmaster with jezek/xgb but it didn't actually make a difference so I don't think that is the cause.
That said it might still make sense to migrate to non-deprecated version of the libraries?

@muesli
Copy link
Owner

muesli commented Mar 22, 2021

I agree, we should migrate to a maintained version of this. Could you do me two favors:

  1. open a ticket for the issue you're seeing, so we can try to reproduce and debug this?
  2. if you already made the switch to jezek's package, could you open a PR for that?

Thank you!

@tenfourty
Copy link
Contributor Author

done, PR created. Will create another issue for the window issues.

@tenfourty
Copy link
Contributor Author

created #13 for the XWindows icon issue.

@muesli muesli closed this as completed Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants